Skip to content

Conversation

@crisbeto
Copy link
Member

Adds an interface for the timepicker input so that users can provide their own if they want. This allows helps avoid a circular dependency.

Fixes #31336.

Adds an interface for the timepicker input so that users can provide their own if they want. This allows helps avoid a circular dependency.

Fixes angular#31336.
@crisbeto crisbeto requested a review from a team as a code owner October 10, 2025 10:24
@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Oct 10, 2025
@crisbeto crisbeto requested review from andrewseguin and mmalerba and removed request for a team October 10, 2025 10:24
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 10, 2025
@crisbeto crisbeto merged commit 7dfabca into angular:main Oct 10, 2025
26 of 29 checks passed
adolgachev pushed a commit to adolgachev/components that referenced this pull request Oct 19, 2025
…#32050)

Adds an interface for the timepicker input so that users can provide their own if they want. This allows helps avoid a circular dependency.

Fixes angular#31336.
@robmv
Copy link

robmv commented Oct 24, 2025

@crisbeto: Sorry for being late to check this, but a simple component implementing MatFormFieldControl and at the same time MatTimepickerConnectedInput will not have conflicting definitions of the property value as T | null and Signal<D | null> respectively?

I think this works with MatTimepickerInput because it uses a mechanism new to me that allow it to not implement directly MatFormFieldControl.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: material/timepicker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(timepicker): Allow mat-timepicker to work with other controls different than input[matTimepicker]

3 participants