Skip to content

Conversation

ok7sai
Copy link
Member

@ok7sai ok7sai commented Oct 14, 2025

This change comes with trade-offs

Pro: This enables a truly flatten tree structure, no wrapper required

<tree>
  <treeitem aria-level="1"></treeitem>
  <treeitem aria-level="2"></treeitem>
  <treeitem aria-level="3"></treeitem>
  <treeitem aria-level="2"></treeitem>
  <treeitem aria-level="1"></treeitem>
</tree>

instead of

<tree>
  <treeitem aria-level="1"></treeitem>
  <treegroup>
    <treeitem aria-level="2"></treeitem>
    <treegroup>
      <treeitem aria-level="3"></treeitem>
    </treegroup>
    <treeitem aria-level="2"></treeitem>
  </treegroup>
  <treeitem aria-level="1"></treeitem>
</tree>

Con: For a nested tree, developers must manually put a role="group" parent to avoid aria-required-parent violation. (treeitem needs a tree or group parent, a treeitem inside a treeitem directly without a group wrapper causes a violation)

<tree>
  <treeitem aria-level="1">
    <treeitem aria-level="2">
      <treeitem aria-level="3"></treeitem>
    </treeitem>
    <treeitem aria-level="2"></treeitem>
  </treeitem>
  <treeitem aria-level="1"></treeitem>
</tree>

above causes violation as group wrappers are required

<tree>
  <treeitem aria-level="1">
    <div role="group">
      <treeitem aria-level="2">
        <div role="group">
          <treeitem aria-level="3"></treeitem>
        </div>
      </treeitem>
      <treeitem aria-level="2"></treeitem>
    </div>
  </treeitem>
  <treeitem aria-level="1"></treeitem>
</tree>

@ok7sai ok7sai requested a review from wagnermaciel October 14, 2025 21:26
@ok7sai ok7sai requested a review from a team as a code owner October 14, 2025 21:26
@ok7sai ok7sai requested review from tjshiu and removed request for a team October 14, 2025 21:26
@ok7sai ok7sai added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Oct 15, 2025
@ok7sai ok7sai removed the request for review from tjshiu October 15, 2025 15:24
@ok7sai ok7sai merged commit 2f094f2 into angular:main Oct 15, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants