fix(aria/combobox): highlighting edge cases #32136
Merged
+108
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagnermaciel
requested review from
andrewseguin,
ok7sai and
tjshiu
and removed request for
a team
ok7sai
approved these changes
Oct 21, 2025
wagnermaciel
added
action: merge
wagnermaciel
added
target: minor
wagnermaciel
added a commit
to wagnermaciel/components
that referenced
this pull request
Nov 3, 2025
* refactor(aria/combobox): move some esc logic * fix(aria/combobox): highlighting edge cases * fixup! fix(aria/combobox): highlighting edge cases * fixup! fix(aria/combobox): highlighting edge cases * fix(aria/combobox): escape behavior * fixup! fix(aria/combobox): highlighting edge cases * fixup! fix(aria/combobox): highlighting edge cases * fix(aria/combobox): calc highlight state on open
wagnermaciel
added a commit
to wagnermaciel/components
that referenced
this pull request
Nov 3, 2025
* refactor(aria/combobox): move some esc logic * fix(aria/combobox): highlighting edge cases * fixup! fix(aria/combobox): highlighting edge cases * fixup! fix(aria/combobox): highlighting edge cases * fix(aria/combobox): escape behavior * fixup! fix(aria/combobox): highlighting edge cases * fixup! fix(aria/combobox): highlighting edge cases * fix(aria/combobox): calc highlight state on open
wagnermaciel
added a commit
to wagnermaciel/components
that referenced
this pull request
Nov 3, 2025
* refactor(aria/combobox): move some esc logic * fix(aria/combobox): highlighting edge cases * fixup! fix(aria/combobox): highlighting edge cases * fixup! fix(aria/combobox): highlighting edge cases * fix(aria/combobox): escape behavior * fixup! fix(aria/combobox): highlighting edge cases * fixup! fix(aria/combobox): highlighting edge cases * fix(aria/combobox): calc highlight state on open
wagnermaciel
added a commit
to wagnermaciel/components
that referenced
this pull request
Nov 3, 2025
* refactor(aria/combobox): move some esc logic * fix(aria/combobox): highlighting edge cases * fixup! fix(aria/combobox): highlighting edge cases * fixup! fix(aria/combobox): highlighting edge cases * fix(aria/combobox): escape behavior * fixup! fix(aria/combobox): highlighting edge cases * fixup! fix(aria/combobox): highlighting edge cases * fix(aria/combobox): calc highlight state on open
wagnermaciel
added a commit
that referenced
this pull request
Nov 3, 2025
* refactor(aria/combobox): move some esc logic * fix(aria/combobox): highlighting edge cases * fixup! fix(aria/combobox): highlighting edge cases * fixup! fix(aria/combobox): highlighting edge cases * fix(aria/combobox): escape behavior * fixup! fix(aria/combobox): highlighting edge cases * fixup! fix(aria/combobox): highlighting edge cases * fix(aria/combobox): calc highlight state on open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.