Skip to content

refactor(ng-dev): extract common pattern for processing async commands in child-process #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

refactor(ng-dev): extract common pattern for processing async commands in child-process #2423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 43 additions & 80 deletions .github/local-actions/branch-manager/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56702,49 +56702,6 @@ var ChildProcess = class {
childProcess.on("close", (status) => status === 0 ? resolve() : reject(status));
});
}
static spawn(command, args, options = {}) {
return new Promise((resolve, reject) => {
const commandText = `${command} ${args.join(" ")}`;
const outputMode = options.mode;
const env3 = getEnvironmentForNonInteractiveCommand(options.env);
Log.debug(`Executing command: ${commandText}`);
const childProcess = _spawn(command, args, { ...options, env: env3, shell: true, stdio: "pipe" });
let logOutput = "";
let stdout = "";
let stderr = "";
if (options.input !== void 0) {
childProcess.stdin.write(options.input);
childProcess.stdin.end();
}
childProcess.stderr.on("data", (message) => {
stderr += message;
logOutput += message;
if (outputMode === void 0 || outputMode === "enabled") {
process.stderr.write(message);
}
});
childProcess.stdout.on("data", (message) => {
stdout += message;
logOutput += message;
if (outputMode === void 0 || outputMode === "enabled") {
process.stderr.write(message);
}
});
childProcess.on("close", (exitCode, signal) => {
const exitDescription = exitCode !== null ? `exit code "${exitCode}"` : `signal "${signal}"`;
const printFn = outputMode === "on-error" ? Log.error : Log.debug;
const status = statusFromExitCodeAndSignal(exitCode, signal);
printFn(`Command "${commandText}" completed with ${exitDescription}.`);
printFn(`Process output:
${logOutput}`);
if (status === 0 || options.suppressErrorOnFailingExitCode) {
resolve({ stdout, stderr, status });
} else {
reject(outputMode === "silent" ? logOutput : void 0);
}
});
});
}
static spawnSync(command, args, options = {}) {
const commandText = `${command} ${args.join(" ")}`;
const env3 = getEnvironmentForNonInteractiveCommand(options.env);
Expand All @@ -56756,44 +56713,14 @@ ${logOutput}`);
}
throw new Error(stderr);
}
static spawn(command, args, options = {}) {
const commandText = `${command} ${args.join(" ")}`;
const env3 = getEnvironmentForNonInteractiveCommand(options.env);
return processAsyncCmd(commandText, options, _spawn(command, args, { ...options, env: env3, shell: true, stdio: "pipe" }));
}
static exec(command, options = {}) {
return new Promise((resolve, reject) => {
var _a2, _b;
const outputMode = options.mode;
const env3 = getEnvironmentForNonInteractiveCommand(options.env);
Log.debug(`Executing command: ${command}`);
const childProcess = _exec(command, { ...options, env: env3 });
let logOutput = "";
let stdout = "";
let stderr = "";
(_a2 = childProcess.stderr) == null ? void 0 : _a2.on("data", (message) => {
stderr += message;
logOutput += message;
if (outputMode === void 0 || outputMode === "enabled") {
process.stderr.write(message);
}
});
(_b = childProcess.stdout) == null ? void 0 : _b.on("data", (message) => {
stdout += message;
logOutput += message;
if (outputMode === void 0 || outputMode === "enabled") {
process.stderr.write(message);
}
});
childProcess.on("close", (exitCode, signal) => {
const exitDescription = exitCode !== null ? `exit code "${exitCode}"` : `signal "${signal}"`;
const printFn = outputMode === "on-error" ? Log.error : Log.debug;
const status = statusFromExitCodeAndSignal(exitCode, signal);
printFn(`Command "${command}" completed with ${exitDescription}.`);
printFn(`Process output:
${logOutput}`);
if (status === 0 || options.suppressErrorOnFailingExitCode) {
resolve({ stdout, stderr, status });
} else {
reject(outputMode === "silent" ? logOutput : void 0);
}
});
});
const env3 = getEnvironmentForNonInteractiveCommand(options.env);
return processAsyncCmd(command, options, _exec(command, { ...options, env: env3 }));
}
};
function statusFromExitCodeAndSignal(exitCode, signal) {
Expand All @@ -56803,6 +56730,42 @@ function getEnvironmentForNonInteractiveCommand(userProvidedEnv) {
const forceColorValue = supports_color_default2.stdout !== false ? supports_color_default2.stdout.level.toString() : void 0;
return { FORCE_COLOR: forceColorValue, ...userProvidedEnv ?? process.env };
}
function processAsyncCmd(command, options, childProcess) {
return new Promise((resolve, reject) => {
var _a2, _b;
let logOutput = "";
let stdout = "";
let stderr = "";
Log.debug(`Executing command: ${command}`);
(_a2 = childProcess.stderr) == null ? void 0 : _a2.on("data", (message) => {
stderr += message;
logOutput += message;
if (options.mode === void 0 || options.mode === "enabled") {
process.stderr.write(message);
}
});
(_b = childProcess.stdout) == null ? void 0 : _b.on("data", (message) => {
stdout += message;
logOutput += message;
if (options.mode === void 0 || options.mode === "enabled") {
process.stderr.write(message);
}
});
childProcess.on("close", (exitCode, signal) => {
const exitDescription = exitCode !== null ? `exit code "${exitCode}"` : `signal "${signal}"`;
const printFn = options.mode === "on-error" ? Log.error : Log.debug;
const status = statusFromExitCodeAndSignal(exitCode, signal);
printFn(`Command "${command}" completed with ${exitDescription}.`);
printFn(`Process output:
${logOutput}`);
if (status === 0 || options.suppressErrorOnFailingExitCode) {
resolve({ stdout, stderr, status });
} else {
reject(options.mode === "silent" ? logOutput : void 0);
}
});
});
}

//
function determineRepoBaseDirFromCwd() {
Expand Down
123 changes: 43 additions & 80 deletions .github/local-actions/changelog/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56575,49 +56575,6 @@ var ChildProcess = class {
childProcess.on("close", (status) => status === 0 ? resolve() : reject(status));
});
}
static spawn(command, args, options = {}) {
return new Promise((resolve, reject) => {
const commandText = `${command} ${args.join(" ")}`;
const outputMode = options.mode;
const env3 = getEnvironmentForNonInteractiveCommand(options.env);
Log.debug(`Executing command: ${commandText}`);
const childProcess = _spawn(command, args, { ...options, env: env3, shell: true, stdio: "pipe" });
let logOutput = "";
let stdout = "";
let stderr = "";
if (options.input !== void 0) {
childProcess.stdin.write(options.input);
childProcess.stdin.end();
}
childProcess.stderr.on("data", (message) => {
stderr += message;
logOutput += message;
if (outputMode === void 0 || outputMode === "enabled") {
process.stderr.write(message);
}
});
childProcess.stdout.on("data", (message) => {
stdout += message;
logOutput += message;
if (outputMode === void 0 || outputMode === "enabled") {
process.stderr.write(message);
}
});
childProcess.on("close", (exitCode, signal) => {
const exitDescription = exitCode !== null ? `exit code "${exitCode}"` : `signal "${signal}"`;
const printFn = outputMode === "on-error" ? Log.error : Log.debug;
const status = statusFromExitCodeAndSignal(exitCode, signal);
printFn(`Command "${commandText}" completed with ${exitDescription}.`);
printFn(`Process output:
${logOutput}`);
if (status === 0 || options.suppressErrorOnFailingExitCode) {
resolve({ stdout, stderr, status });
} else {
reject(outputMode === "silent" ? logOutput : void 0);
}
});
});
}
static spawnSync(command, args, options = {}) {
const commandText = `${command} ${args.join(" ")}`;
const env3 = getEnvironmentForNonInteractiveCommand(options.env);
Expand All @@ -56629,44 +56586,14 @@ ${logOutput}`);
}
throw new Error(stderr);
}
static spawn(command, args, options = {}) {
const commandText = `${command} ${args.join(" ")}`;
const env3 = getEnvironmentForNonInteractiveCommand(options.env);
return processAsyncCmd(commandText, options, _spawn(command, args, { ...options, env: env3, shell: true, stdio: "pipe" }));
}
static exec(command, options = {}) {
return new Promise((resolve, reject) => {
var _a2, _b;
const outputMode = options.mode;
const env3 = getEnvironmentForNonInteractiveCommand(options.env);
Log.debug(`Executing command: ${command}`);
const childProcess = _exec(command, { ...options, env: env3 });
let logOutput = "";
let stdout = "";
let stderr = "";
(_a2 = childProcess.stderr) == null ? void 0 : _a2.on("data", (message) => {
stderr += message;
logOutput += message;
if (outputMode === void 0 || outputMode === "enabled") {
process.stderr.write(message);
}
});
(_b = childProcess.stdout) == null ? void 0 : _b.on("data", (message) => {
stdout += message;
logOutput += message;
if (outputMode === void 0 || outputMode === "enabled") {
process.stderr.write(message);
}
});
childProcess.on("close", (exitCode, signal) => {
const exitDescription = exitCode !== null ? `exit code "${exitCode}"` : `signal "${signal}"`;
const printFn = outputMode === "on-error" ? Log.error : Log.debug;
const status = statusFromExitCodeAndSignal(exitCode, signal);
printFn(`Command "${command}" completed with ${exitDescription}.`);
printFn(`Process output:
${logOutput}`);
if (status === 0 || options.suppressErrorOnFailingExitCode) {
resolve({ stdout, stderr, status });
} else {
reject(outputMode === "silent" ? logOutput : void 0);
}
});
});
const env3 = getEnvironmentForNonInteractiveCommand(options.env);
return processAsyncCmd(command, options, _exec(command, { ...options, env: env3 }));
}
};
function statusFromExitCodeAndSignal(exitCode, signal) {
Expand All @@ -56676,6 +56603,42 @@ function getEnvironmentForNonInteractiveCommand(userProvidedEnv) {
const forceColorValue = supports_color_default2.stdout !== false ? supports_color_default2.stdout.level.toString() : void 0;
return { FORCE_COLOR: forceColorValue, ...userProvidedEnv ?? process.env };
}
function processAsyncCmd(command, options, childProcess) {
return new Promise((resolve, reject) => {
var _a2, _b;
let logOutput = "";
let stdout = "";
let stderr = "";
Log.debug(`Executing command: ${command}`);
(_a2 = childProcess.stderr) == null ? void 0 : _a2.on("data", (message) => {
stderr += message;
logOutput += message;
if (options.mode === void 0 || options.mode === "enabled") {
process.stderr.write(message);
}
});
(_b = childProcess.stdout) == null ? void 0 : _b.on("data", (message) => {
stdout += message;
logOutput += message;
if (options.mode === void 0 || options.mode === "enabled") {
process.stderr.write(message);
}
});
childProcess.on("close", (exitCode, signal) => {
const exitDescription = exitCode !== null ? `exit code "${exitCode}"` : `signal "${signal}"`;
const printFn = options.mode === "on-error" ? Log.error : Log.debug;
const status = statusFromExitCodeAndSignal(exitCode, signal);
printFn(`Command "${command}" completed with ${exitDescription}.`);
printFn(`Process output:
${logOutput}`);
if (status === 0 || options.suppressErrorOnFailingExitCode) {
resolve({ stdout, stderr, status });
} else {
reject(options.mode === "silent" ? logOutput : void 0);
}
});
});
}

//
function determineRepoBaseDirFromCwd() {
Expand Down
Loading