feat(ng-dev/ts-circular-dependencies): make golden file optional #2600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
changed the title
The framework repo currently has no circular dependencies and does not allow new ones. This change makes the golden file optional so that framework can remove its empty golden file & associated pullapprove config
josephperrott
approved these changes
Feb 19, 2025
Member
josephperrott
left a comment
josephperrott
left a comment
There was a problem hiding this comment.
LGTM
This will function as expected, but now as I look through the code there are a number of refactors I would like us to make here, but I will do those in a follow up.
Member
|
This PR was merged into the repository by commit 89fd28e. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The framework repo currently has no circular dependencies and does not allow new ones. This change makes the golden file optional so that framework can remove its empty golden file & associated pullapprove config