Skip to content

fix(bazel): forward provided module names for interop compatible ts_projects #2612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(bazel): forward provided module names for interop compatible ts_projects #2612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions bazel/ts_project/strict_deps/index.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,18 @@
load("@aspect_rules_js//js:providers.bzl", "JsInfo")
load("@build_bazel_rules_nodejs//:providers.bzl", "LinkablePackageInfo")

# A custom provider to pass along the npm package name for linked npm packages
NpmPackage = provider()

def _npm_package_aspect_impl(target, ctx):
# Extract the module_name provided to an interop compatible ts_project to be made
# available as an imported module by downstream usages.
# TODO: Remove after all interop usage is removed.
if ctx.rule.kind == "ts_project_module":
package_name = target[LinkablePackageInfo].package_name
if package_name != "":
return [NpmPackage(name = package_name)]

if (ctx.rule.kind == "npm_link_package_store"):
package_name = ctx.rule.attr.package

Expand Down
Loading