Skip to content

fix(bazel/api-golden): do not try to read golden in approve mode #2666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

fix(bazel/api-golden): do not try to read golden in approve mode #2666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions bazel/api-golden/index_npm_packages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ async function main(
const goldenFilePath = path.join(goldenDir, goldenName);
const moduleName = normalizePathToPosix(path.join(packageJson.name, subpath));

const expected = fs.readFileSync(goldenFilePath, 'utf8');
const actual = await testApiGolden(
typesEntryPointPath,
stripExportPattern,
Expand All @@ -67,17 +66,17 @@ async function main(
process.exit(1);
}

// Keep track of outdated goldens.
if (actual !== expected) {
if (approveGolden) {
fs.mkdirSync(path.dirname(goldenFilePath), {recursive: true});
fs.writeFileSync(goldenFilePath, actual, 'utf8');
} else {
if (approveGolden) {
fs.mkdirSync(path.dirname(goldenFilePath), {recursive: true});
fs.writeFileSync(goldenFilePath, actual, 'utf8');
} else {
const expected = fs.readFileSync(goldenFilePath, 'utf8');
if (actual !== expected) {
// Keep track of outdated goldens for error message.
outdatedGoldens.push(goldenName);
allTestsSucceeding = false;
}
}

allTestsSucceeding = allTestsSucceeding && actual === expected;
}

if (outdatedGoldens.length) {
Expand Down