feat(bazel): support PORT environment variable in http_server
#2724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be useful for a more generic `server_test` rule.
josephperrott
approved these changes
Apr 9, 2025
| .option('port', {type: 'number', default: 4200}) | ||
| .option('port', { | ||
| type: 'number', | ||
| default: process.env['PORT'] !== undefined ? Number(process.env['PORT']) : 4200, |
Member
There was a problem hiding this comment.
Do we want to do a NaN check as well? Probably not strictly necessary, but figured I would ask.
Member
Author
There was a problem hiding this comment.
I did consider it, but a runtime error is okay if this is off IMO; so will merge for now
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful for a more generic
server_testrule.