a couple fixes for dns redirecting #2756
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sent on dns redirect Previously the response redirect would complete the http response, but then we would attempt to still provide a status response and message, which caused errors throughout our logging. The correct action is to no longer perform response actions after a redirect.
…of material.angular.io subdomains The subdomains attr on the request object is actually in reverse order of the subdomains as they are made in the request, because of this we simply put the subdomains back in the original order replacing only the hostname with angular.dev instead of angular.io.
josephperrott
changed the title
clydin
approved these changes
Apr 30, 2025
Member
Author
|
This PR was merged into the repository by commit a4538b2. The changes were merged into the following branches: main |
josephperrott
added a commit
that referenced
this pull request
Apr 30, 2025
…of material.angular.io subdomains (#2756) The subdomains attr on the request object is actually in reverse order of the subdomains as they are made in the request, because of this we simply put the subdomains back in the original order replacing only the hostname with angular.dev instead of angular.io. PR Close #2756
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the response redirect would complete the http response, but then we would attempt to still provide a status response and message, which caused errors throughout our logging. The correct action is to no longer perform response actions after a redirect.