feat(ng-dev): update renovate.json baseBranches when creating a new branch
#2772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
baseBranches
branch
4 times, most recently
from
e54eaa7 to
3ca73c5
Compare
devversion
reviewed
May 9, 2025
ng-dev/release/publish/actions.ts
Outdated
| const baseBranches = configJson.baseBranches; | ||
| if (!Array.isArray(baseBranches) || baseBranches.length !== 2) { | ||
| spinner.success( | ||
| yellow('Skipped updating Renovate config: "baseBranches" must contain exactly 2 branches.'), |
Member
There was a problem hiding this comment.
Aren't there cases where we also want to update patch, rc and main?
Contributor
Author
There was a problem hiding this comment.
Good question. I think once the feature freeze begins, changes to the patch branch should be kept minimal to maintain stability, especially since it's heading to LTS soon.
Also, running Renovate on three branches would significantly increase runtime not to mention PRs will take longer to open due to rate limits.
… branch Adds support for automatically modifying `renovate.json` to include newly created branches in the `baseBranches` array, when `updateRenovateConfig` is enabled.
devversion
approved these changes
May 9, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for automatically modifying
renovate.jsonto include newly created branches in thebaseBranchesarray, whenupdateRenovateConfigis enabled.