Skip to content

refactor(bazel): drop interop support for http_server #2930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

refactor(bazel): drop interop support for http_server #2930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions bazel/http-server/index.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
load("@aspect_rules_js//js:providers.bzl", "JsInfo")
load("@build_bazel_rules_nodejs//:providers.bzl", "JSNamedModuleInfo")

def _get_workspace_name(ctx):
if ctx.label.workspace_root:
Expand Down Expand Up @@ -28,8 +27,6 @@ def _http_server_rule_impl(ctx):
# unwrapped in case there are built using TypeScript-specific rules.
transitive_depsets = []
for dep in ctx.attr.deps:
if JSNamedModuleInfo in dep:
transitive_depsets.append(dep[JSNamedModuleInfo].sources)
if JsInfo in dep:
transitive_depsets.append(dep[JsInfo].transitive_sources)
elif DefaultInfo in dep:
Expand Down