Skip to content

fix(bazel): relax node.js check in integration checks #2969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025
Merged

fix(bazel): relax node.js check in integration checks #2969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bazel/integration/index.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,9 @@ def _unwrap_label_keyed_mappings(ctx, dict, description):
# The nodejs toolchain now provides node and npm binaries, as long as node is the first file
# provided in the DefaultInfo files list, we continue as expected.
if name == "node":
if (len(files) != 2 or not files[0].short_path.endswith("bin/node")):
fail("Expected %s target %s to be an provide two files, of which the first is `node`")
# TODO: replace `> 2` with `!= 2` when migration from the old nodejs_toolchain
if (len(files) > 2 or not files[0].short_path.endswith("bin/node")):
fail("Expected %s target %s to be an provide up to two files, of which the first is `node`." % (description, target))

# For all non-node, we expect a single file or an executable which will only have one file.
elif len(files) != 1:
Expand Down