build: enable strict deps enforcement for ts_project

apps/code-of-conduct/BUILD.bazel

@@ -15,6 +15,7 @@ ng_project(
         ":node_modules/@angular/animations",
         ":node_modules/@angular/common",
         ":node_modules/@angular/compiler",
+        ":node_modules/@angular/core",
         ":node_modules/@angular/fire",
         ":node_modules/@angular/platform-browser",
         ":node_modules/@angular/router",

apps/code-of-conduct/app/BUILD.bazel

@@ -14,6 +14,7 @@ ng_project(
     deps = [
         "//apps/code-of-conduct:node_modules/@angular/common",
         "//apps/code-of-conduct:node_modules/@angular/core",
+        "//apps/code-of-conduct:node_modules/@angular/material",
         "//apps/code-of-conduct:node_modules/@angular/router",
         "//apps/code-of-conduct/app/account",
         "//apps/code-of-conduct/app/block-user",

apps/code-of-conduct/app/app.component.ts

@@ -2,8 +2,6 @@ import {Component} from '@angular/core';
 import {MatToolbarModule} from '@angular/material/toolbar';
 import {RouterModule} from '@angular/router';
 import {AccountComponent} from './account/account.component.js';
-import {BlockUserComponent} from './block-user/block-user.component.js';
-import {UserTableComponent} from './user-table/user-table.component.js';
 
 @Component({
   standalone: true,

apps/code-of-conduct/app/login/BUILD.bazel

@@ -13,6 +13,7 @@ ng_project(
         "//apps/code-of-conduct:node_modules/@angular/common",
         "//apps/code-of-conduct:node_modules/@angular/core",
         "//apps/code-of-conduct:node_modules/@angular/material",
+        "//apps/code-of-conduct:node_modules/@angular/router",
         "//apps/code-of-conduct/app/account",
     ],
 )

bazel/ts_project/strict_deps/index.mts

@@ -56,9 +56,7 @@ function checkPathsForMatch(moduleSpecifier: string, paths?: ts.MapLike<string[]
 const knownModuleSpecifiersWithExtensions = new Set(['highlight.js', 'zone.js']);
 
 for (const fileExecPath of manifest.testFiles) {
-  const content = await fs.readFile(fileExecPath, 'utf8');
-  const sf = ts.createSourceFile(fileExecPath, content, ts.ScriptTarget.ESNext, true);
-  const imports = getImportsInSourceFile(sf);
+  const imports = getImportsInSourceFile(fileExecPath);
 
   for (const i of imports) {
     const moduleSpecifier = knownModuleSpecifiersWithExtensions.has(i.moduleSpecifier)

bazel/ts_project/strict_deps/visitor.mts

@@ -7,17 +7,28 @@
  */
 
 import ts from 'typescript';
+import fs from 'node:fs';
 
 export interface Import {
   diagnosticNode: ts.Node;
   moduleSpecifier: string;
 }
 
-export function getImportsInSourceFile(sf: ts.SourceFile): Import[] {
+export function getImportsInSourceFile(fileExecPath: string): Import[] {
+  const content = fs.readFileSync(fileExecPath, 'utf8');
+  const sf = ts.createSourceFile(fileExecPath, content, ts.ScriptTarget.ESNext, true);
   const result: Import[] = [];
 
   const visitor = (node: ts.Node) => {
     if (ts.isImportDeclaration(node) || ts.isExportDeclaration(node)) {
+      const leadingComments = ts.getLeadingCommentRanges(content, node.pos) || [];
+      for (const comment of leadingComments) {
+        const commentText = content.substring(comment.pos, comment.end);
+        if (/@ts-ignore.*strict-deps/.test(commentText)) {
+          return;
+        }
+      }
+
       const moduleSpecifier = node.moduleSpecifier as ts.StringLiteral;
       // If not moduleSpecifier is included in the declaration, it is infered to be the local file,
       // essentially a self import and can be ignored.

github-actions/bazel/configure-remote/index.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-// @ts-ignore-next-line
+// @ts-ignore-next-line strict-deps
 import tokenRaw from './gcp_token.data';
 import {k, iv, alg, at} from './constants.js';
 import {createDecipheriv} from 'crypto';

github-actions/browserstack/index.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-// @ts-ignore
+// @ts-ignore-next-line strict-deps
 import tokenRaw from './browserstack_token.data';
 import {k, iv, alg, at} from './constants.js';
 import {createDecipheriv} from 'crypto';

github-actions/saucelabs/index.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-// @ts-ignore
+// @ts-ignore-next-line strict-deps
 import tokenRaw from './saucelabs_token.data';
 import {k, iv, alg, at} from './constants.js';
 import {createDecipheriv} from 'crypto';

tools/defaults.bzl

@@ -10,6 +10,7 @@ load("@rules_angular//src/ng_project:index.bzl", _ng_project = "ng_project")
 load("@rules_angular//src/ts_project:index.bzl", _ts_project = "ts_project")
 load("@rules_sass//src:index.bzl", _npm_sass_library = "npm_sass_library", _sass_binary = "sass_binary")
 load("//bazel:extract_types.bzl", _extract_types = "extract_types")
+load("//bazel/ts_project:index.bzl", _strict_deps_test = "strict_deps_test")
 
 copy_to_bin = _copy_to_bin
 ts_config = _ts_config
@@ -28,6 +29,8 @@ def _determine_tsconfig(testonly):
 
 def ts_project(
         name,
+        srcs = [],
+        deps = [],
         source_map = True,
         testonly = False,
         tsconfig = None,
@@ -38,35 +41,53 @@ def ts_project(
 
     _ts_project(
         name,
+        deps = deps,
+        srcs = srcs,
         source_map = source_map,
         testonly = testonly,
         tsconfig = tsconfig,
         declaration = declaration,
         **kwargs
     )
 
+    _strict_deps_test(
+        name = "%s_strict_deps_test" % name,
+        tsconfig = tsconfig,
+        deps = deps,
+        srcs = srcs,
+    )
+
 def ng_project(
         name,
+        srcs = [],
+        deps = [],
         source_map = True,
         testonly = False,
         tsconfig = None,
         declaration = True,
-        deps = [],
         **kwargs):
     if tsconfig == None:
         tsconfig = _determine_tsconfig(testonly)
 
     deps = deps + ["//:node_modules/tslib"]
     _ng_project(
         name,
+        deps = deps,
+        srcs = srcs,
         source_map = source_map,
         declaration = declaration,
         testonly = testonly,
         tsconfig = tsconfig,
-        deps = deps,
         **kwargs
     )
 
+    _strict_deps_test(
+        name = "%s_strict_deps_test" % name,
+        tsconfig = tsconfig,
+        deps = deps,
+        srcs = srcs,
+    )
+
 def npm_package(name, srcs = [], substitutions = {}, **kwargs):
     _text_replace(
         name = "%s_substituted" % name,