Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/local-actions/labels-sync/lib/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ async function syncLabelsInRepo(github: Octokit, repoName: string, managedLabels

async function main() {
/** The Github API instance to use for requests. */
// TODO: remove once GHA supports node18 as a target runner for Javascript action
const github = new Octokit({auth: await getAuthTokenFor(ANGULAR_ROBOT)});

try {
Expand Down
2 changes: 1 addition & 1 deletion .github/local-actions/labels-sync/main.js

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion .github/local-actions/lock-closed/lib/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ async function main() {
const token = await getAuthTokenFor(ANGULAR_LOCK_BOT, {org: 'angular'});

try {
// TODO: remove once GHA supports node18 as a target runner for Javascript action
const github = new Octokit({auth: token});
for (let repo of reposToBeChecked) {
await runLockClosedAction(github, repo);
Expand Down
2 changes: 1 addition & 1 deletion .github/local-actions/lock-closed/main.js

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions github-actions/post-approval-changes/lib/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,10 @@ async function main() {
const repoToken = await getAuthTokenFor(ANGULAR_ROBOT, context.repo);
const googlersOrgToken = await getGooglersOrgInstallationToken();

// TODO: remove once GHA supports node18 as a target runner for Javascript action
repoClient = new Octokit({auth: repoToken, request: {fetch}});
repoClient = new Octokit({auth: repoToken});

if (googlersOrgToken !== null) {
googlersOrgClient = new Octokit({auth: googlersOrgToken, request: {fetch}});
googlersOrgClient = new Octokit({auth: googlersOrgToken});
}

await runPostApprovalChangesAction(googlersOrgClient ?? repoClient, repoClient);
Expand Down
6 changes: 3 additions & 3 deletions github-actions/post-approval-changes/main.js

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion github-actions/pull-request-labeling/lib/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ class PullRequestLabeling {
/** Run the commit message based labelling process. */
static run = async () => {
const token = await getAuthTokenFor(ANGULAR_ROBOT);
// TODO: remove once GHA supports node18 as a target runner for Javascript action
const git = new Octokit({auth: token});
try {
const inst = new this(git);
Expand Down
2 changes: 1 addition & 1 deletion github-actions/pull-request-labeling/main.js

Large diffs are not rendered by default.