refactor(ng-dev): centralize commit count logic in API merge strategy #3186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
commit-count
branch
from
9daab7d to
fa9a55e
Compare
The `pullRequestCommitCount` was being conditionally reassigned in multiple places within the GithubApiMergeStrategy. This duplicated logic and made it harder to follow. This change refactors the logic to determine the commit count in a single location using a ternary operator, improving readability and maintainability.
alan-agius4
force-pushed
the
commit-count
branch
from
fa9a55e to
47cf742
Compare
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pullRequestCommitCountwas being conditionally reassigned in multiple places within the GithubApiMergeStrategy. This duplicated logic and made it harder to follow.This change refactors the logic to determine the commit count in a single location using a ternary operator, improving readability and maintainability.