fix: disable rename feature when strictTemplates is disabled

When `strictTemplates` is disabled, we know that the compiler's view of a template
is not completely "accurate". That is, the compiler's generated Type
Check Blocks will not have sufficient type information to properly
perform a rename operation.

Author: atscott

integration/lsp/ivy_spec.ts

@@ -274,16 +274,42 @@ describe('Angular Ivy language server', () => {
       fs.writeFileSync(TSCONFIG, originalConfig);
     });
 
-    it('should suggest strict mode', async () => {
-      const config = JSON.parse(originalConfig);
-      config.angularCompilerOptions.strictTemplates = false;
-      fs.writeFileSync(TSCONFIG, JSON.stringify(config, null, 2));
-
-      openTextDocument(client, APP_COMPONENT);
-      const languageServiceEnabled = await waitForNgcc(client);
-      expect(languageServiceEnabled).toBeTrue();
-      const configFilePath = await onSuggestStrictMode(client);
-      expect(configFilePath.endsWith('integration/project/tsconfig.json')).toBeTrue();
+    describe('strictTemplates: false', () => {
+      beforeEach(async () => {
+        const config = JSON.parse(originalConfig);
+        config.angularCompilerOptions.strictTemplates = false;
+        fs.writeFileSync(TSCONFIG, JSON.stringify(config, null, 2));
+
+        openTextDocument(client, APP_COMPONENT);
+        const languageServiceEnabled = await waitForNgcc(client);
+        expect(languageServiceEnabled).toBeTrue();
+      });
+
+      it('should suggest strict mode', async () => {
+        const configFilePath = await onSuggestStrictMode(client);
+        expect(configFilePath.endsWith('integration/project/tsconfig.json')).toBeTrue();
+      });
+
+      it('should disable renaming when strict mode is disabled', async () => {
+        await onSuggestStrictMode(client);
+
+        const prepareRenameResponse = await client.sendRequest(lsp.PrepareRenameRequest.type, {
+          textDocument: {
+            uri: `file://${APP_COMPONENT}`,
+          },
+          position: {line: 4, character: 25},
+        }) as {range: lsp.Range, placeholder: string};
+        expect(prepareRenameResponse).toBeNull();
+
+        const renameResponse = await client.sendRequest(lsp.RenameRequest.type, {
+          textDocument: {
+            uri: `file://${APP_COMPONENT}`,
+          },
+          position: {line: 4, character: 25},
+          newName: 'surname'
+        });
+        expect(renameResponse).toBeNull();
+      });
     });
   });
 });

server/src/session.ts

@@ -49,6 +49,13 @@ export class Session {
   private readonly logToConsole: boolean;
   private diagnosticsTimeout: NodeJS.Timeout|null = null;
   private isProjectLoading = false;
+  /**
+   * Tracks which `ts.server.Project`s have the renaming capability disabled.
+   *
+   * If we detect the compiler options diagnostic that suggests enabling strict mode, we want to
+   * disable renaming because we know that there are many cases where it will not work correctly.
+   */
+  private renameDisabledProjects: WeakSet<ts.server.Project> = new WeakSet();
 
   constructor(options: SessionOptions) {
     this.logger = options.logger;
@@ -217,6 +224,9 @@ export class Session {
         configFilePath,
         message: suggestStrictModeDiag.messageText,
       });
+      this.renameDisabledProjects.add(project);
+    } else {
+      this.renameDisabledProjects.delete(project);
     }
   }
 
@@ -543,6 +553,11 @@ export class Session {
       // provide consistent expectations.
       return;
     }
+    const project = this.getDefaultProjectForScriptInfo(scriptInfo);
+    if (project === undefined || this.renameDisabledProjects.has(project)) {
+      return;
+    }
+
     const offset = lspPositionToTsPosition(scriptInfo, params.position);
     const renameLocations = languageService.findRenameLocations(
         scriptInfo.fileName, offset, /*findInStrings*/ false, /*findInComments*/ false);
@@ -581,6 +596,11 @@ export class Session {
       // provide consistent expectations.
       return;
     }
+    const project = this.getDefaultProjectForScriptInfo(scriptInfo);
+    if (project === undefined || this.renameDisabledProjects.has(project)) {
+      return;
+    }
+
     const offset = lspPositionToTsPosition(scriptInfo, params.position);
     const renameInfo = languageService.getRenameInfo(scriptInfo.fileName, offset);
     if (!renameInfo.canRename) {