This repository was archived by the owner on Nov 21, 2025. It is now read-only.
fix: replace the closing symbol for inputs/outputs. #2142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Angular Language Service does not return `InsertReplaceEdit`.
There is no need to allow the developer to choose how to insert the completion.
For example, `<button (c|) />`.
^^__________Insert edit
^^ ^________Replace edit
If the LS returns the `InsertReplaceEdit` as shown above, selecting "Insert" by the developer
results in `(click)="")`, and selecting "Replace" results in `(click)=""`.
Now in the vscode, the default `editor.suggest.insertMode` value for HTML is `Replace`, for
ts is `Insert`, So this leads to a bug in the ts file.
Fixes angular#2137
Contributor
Author
|
This also reverts the commit. PTAL @atscott more info here #2137 (comment) |
atscott
approved these changes
Feb 12, 2025
Collaborator
atscott
left a comment
atscott
left a comment
There was a problem hiding this comment.
LGTM with the caveat that this applies to all completions, not just inputs and outputs with their parens/braces. This effectively removes the support for insert mode and uses replace everywhere.
atscott
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Angular Language Service does not return
InsertReplaceEdit. There is no need to allow the developer to choose how to insert the completion.If the LS returns the
InsertReplaceEditas shown above, selecting "Insert" by the developer results in(click)=""), and selecting "Replace" results in(click)="".Now in the vscode, the default
editor.suggest.insertModevalue for HTML isReplace, for ts isInsert, So this leads to a bug in the ts file.Fixes #2137