This repository was archived by the owner on Nov 21, 2025. It is now read-only.
feat: add support for host bindings #2155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
approved these changes
Mar 14, 2025
Makes the necessary changes on the vscode extension side to enable angular/angular#60267, including: * Looking for completions, quick info etc inside the `host` property. * Syntax highlighting for the `host` object literal.
Member
Author
|
I had to change the approach here a bit, because the previous one wasn't accounting for a bunch of TS syntax like spread expressions or escaped strings. The new approach will fall back to the TS highlighting if our patterns don't match anything and it should be a bit more robust. |
crisbeto
added
action: merge
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Mar 18, 2025
Reworks the language service to enable features like quick info and definitions inside host bindings. **Note:** for the full range of language service features to work, the changes from angular/vscode-ng-language-service#2155 have to be released.
pkozlowski-opensource
pushed a commit
to angular/angular
that referenced
this pull request
Mar 18, 2025
Reworks the language service to enable features like quick info and definitions inside host bindings. **Note:** for the full range of language service features to work, the changes from angular/vscode-ng-language-service#2155 have to be released. PR Close #60433
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the necessary changes on the vscode extension side to enable angular/angular#60267, including:
hostproperty.hostobject literal.