feat: support configuring custom endpoints in loader scripts #28
Conversation
| } from '../runner/reporting/report-local-disk'; | ||
|
|
||
| const app = express(); | ||
| const reportsLoaderPromise = getReportLoader(); |
There was a problem hiding this comment.
The reason why I had it set up this way with a lazy promise was that the CLI's dev server was a bit flaky if the the boot-up sequence for the Express server is asynchronous. I think we may have to keep that so it shows up reliably.
There was a problem hiding this comment.
What do you mean with flaky?
I saw some flakiness/or delay of the server when booting up, but that was because we printed the "Server is ready at: localhost:XX" too early. I've fixed this by leveraging the Express "listen" callback
There was a problem hiding this comment.
It was happening either if I had the server already running and I restarted it, or if I go to localhost:4200 too quickly. The CLI would throw some error since the server hadn't booted up yet.
There was a problem hiding this comment.
I haven't seen anything like this (after adding the listen Express hook). How do we proceed?
We need to await so that we can hook up endpoints.
There was a problem hiding this comment.
Let's proceed as is and we can think of something else if it shows up again.
| } from '../runner/reporting/report-local-disk'; | ||
|
|
||
| const app = express(); | ||
| const reportsLoaderPromise = getReportLoader(); |
There was a problem hiding this comment.
Let's proceed as is and we can think of something else if it shows up again.
This is useful for advanced users who might upload images to e.g. Firebase Storage and then want to proxy image URLs to augment with an `Authorization` header.
devversion
force-pushed
the
configure-endpoints
branch
from
2ac84a6 to
c47d6e2
Compare
2 participants
This is useful for advanced users who might upload images to e.g. Firebase Storage and then want to proxy image URLs to augment with an
Authorizationheader.