refactor(runner): replace gpt-tokenizer with tiktoken #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
approved these changes
Sep 21, 2025
| return tokens.length; | ||
| } finally { | ||
| encoding.free(); | ||
| } |
There was a problem hiding this comment.
Nit: we may want to extract this into a helper? and pass the model name + prompt? (seems re-used 3 times)
danielsogl
force-pushed
the
refactor/replace_gpt_tokenizer
branch
from
a7996a4 to
c4e130f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from gpt-tokenizer to tiktoken for better maintenance, official OpenAI support, and native GPT-5 encoding support.
Why the change?
support)