feat: automatically migrate v2 to v3 reports #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've recently made breaking changes with angular@41ada54, and we want to ensure existing reports for users continue to work. This commit lazily migrates v2 to v3 reports when loaded. We can keep this logic for a while; while we also migrate our own Firebase database for permanent storage (maybe we need to expose this script for users as well eventually).
devversion
commented
Sep 29, 2025
| * Migrates a v2 report to a v3 report. | ||
| * See: https://github.com/angular/web-codegen-scorer/commit/41ada541481a10c99de055ab6bb1c19b06a25b88. | ||
| */ | ||
| export function convertV2ReportToV3Report(doc: any) { |
There was a problem hiding this comment.
Maybe it's worth starting to keep the v2 interfaces?
There was a problem hiding this comment.
I'd be a bit concerned that things will become hard to maintain if we keep making changes to the report shape.
There was a problem hiding this comment.
As discussed offline, we can always trim these when there will be too much and make a clear breaking change. Plus we don't necessarily anticipate many more report structure changes.
crisbeto
approved these changes
Sep 29, 2025
| * Migrates a v2 report to a v3 report. | ||
| * See: https://github.com/angular/web-codegen-scorer/commit/41ada541481a10c99de055ab6bb1c19b06a25b88. | ||
| */ | ||
| export function convertV2ReportToV3Report(doc: any) { |
There was a problem hiding this comment.
I'd be a bit concerned that things will become hard to maintain if we keep making changes to the report shape.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently made breaking changes with
41ada54, and we want to ensure existing reports for users continue to work.
This commit lazily migrates v2 to v3 reports when loaded. We can keep this logic for a while; while we also migrate our own Firebase database for permanent storage (maybe we need to expose this script for users as well eventually).