Skip to content

fix: ensure runtime errors are always collected #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

fix: ensure runtime errors are always collected #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions runner/workers/serve-testing/worker-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,25 +15,20 @@ export interface ServeTestingWorkerMessage {
serveUrl: string;
/** Name of the app. */
appName: string;
/**
* Whether this application should be invoked via Puppeteer and
* runtime errors should be collected and reported.
*/
collectRuntimeErrors?: boolean;
/**
* Whether to take a screenshot of the application.
*/
takeScreenshots?: boolean;
takeScreenshots: boolean;
/**
* Whether or not to perform Axe testing of the application.
*/
includeAxeTesting?: boolean;
includeAxeTesting: boolean;

/** Whether to enable the auto CSP checks. */
enableAutoCsp?: boolean;
enableAutoCsp: boolean;

/** User journey browser agent task input */
userJourneyAgentTaskInput?: BrowserAgentTaskInput;
userJourneyAgentTaskInput: BrowserAgentTaskInput | undefined;
}

export interface ServeTestingResult {
Expand Down
6 changes: 2 additions & 4 deletions runner/workers/serve-testing/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ process.on('message', async (message: ServeTestingWorkerMessage) => {
const {
appName,
serveUrl,
collectRuntimeErrors,
enableAutoCsp,
includeAxeTesting,
takeScreenshots,
Expand Down Expand Up @@ -57,9 +56,8 @@ process.on('message', async (message: ServeTestingWorkerMessage) => {
screenshotBase64Data = puppeteerResult.screenshotBase64Data;
axeViolations = puppeteerResult.axeViolations;
cspViolations = puppeteerResult.cspViolations;
if (collectRuntimeErrors) {
runtimeErrors.push(...puppeteerResult.runtimeErrors);
}

runtimeErrors.push(...puppeteerResult.runtimeErrors);

if (userJourneyAgentTaskInput) {
userJourneyAgentOutput = await runBrowserAgentUserJourneyTests(
Expand Down
Loading