Skip to content

QuantityInfo: internalizing the UnitInfo construction #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 25, 2025
Merged

QuantityInfo: internalizing the UnitInfo construction #1555

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cafd93f
- QuantityInfo: internalizing the UnitInfo construction
lipchev Apr 21, 2025
cae7d78
Merge branch 'master' into quantity-info-definition
lipchev Apr 21, 2025
b3844a6
refactored the Quantity methods using the QuantityInfo and removed th…
lipchev Apr 21, 2025
65ba6f6
updating the affected benchmarks
lipchev Apr 23, 2025
272252a
adding the QuantityInfoInitializationBenchmarks
lipchev Apr 23, 2025
1f504da
Merge branch 'master' into quantity-info-definition
angularsen Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions UnitsNet.Benchmark/Conversions/FromString/QuantityFromStringBenchmarks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace UnitsNet.Benchmark.Conversions.FromString;

[MemoryDiagnoser]
[SimpleJob(RuntimeMoniker.Net48)]
[SimpleJob(RuntimeMoniker.Net80)]
[SimpleJob(RuntimeMoniker.Net90)]
public class QuantityFromStringBenchmarks
{
private static readonly CultureInfo Culture = CultureInfo.InvariantCulture;
Expand All @@ -28,20 +28,20 @@ public void PrepareMassStrings()
_quantitiesToParse = _random.GetItems(["kg", "lbs", "Mlbs"], NbAbbreviations).Select(abbreviation => $"{ValueToParse} {abbreviation}").ToArray();
}

[GlobalSetup(Target = nameof(FromVolumeUnitAbbreviation))]
[GlobalSetup(Target = nameof(FromVolumeString))]
public void PrepareVolumeStrings()
{
_quantitiesToParse = _random.GetItems(["ml", "l", "cm³", "m³"], NbAbbreviations).Select(abbreviation => $"{ValueToParse} {abbreviation}").ToArray();;
}

[GlobalSetup(Target = nameof(FromPressureUnitAbbreviation))]
public void PreparePressureUnits()
[GlobalSetup(Target = nameof(FromPressureString))]
public void PreparePressureStrings()
{
_quantitiesToParse = _random.GetRandomAbbreviations<PressureUnit>(UnitsNetSetup.Default.UnitAbbreviations, NbAbbreviations).Select(abbreviation => $"{ValueToParse} {abbreviation}").ToArray();;
}

[GlobalSetup(Target = nameof(FromVolumeFlowUnitAbbreviation))]
public void PrepareVolumeFlowUnits()
[GlobalSetup(Target = nameof(FromVolumeFlowString))]
public void PrepareVolumeFlowStrings()
{
// can't have "bpm" (see Frequency)
_quantitiesToParse =
Expand All @@ -63,7 +63,7 @@ public IQuantity FromMassString()
}

[Benchmark(Baseline = false)]
public IQuantity FromVolumeUnitAbbreviation()
public IQuantity FromVolumeString()
{
IQuantity quantity = null;
foreach (var quantityString in _quantitiesToParse)
Expand All @@ -75,7 +75,7 @@ public IQuantity FromVolumeUnitAbbreviation()
}

[Benchmark(Baseline = false)]
public IQuantity FromPressureUnitAbbreviation()
public IQuantity FromPressureString()
{
IQuantity quantity = null;
foreach (var quantityString in _quantitiesToParse)
Expand All @@ -87,7 +87,7 @@ public IQuantity FromPressureUnitAbbreviation()
}

[Benchmark(Baseline = false)]
public IQuantity FromVolumeFlowUnitAbbreviation()
public IQuantity FromVolumeFlowString()
{
IQuantity quantity = null;
foreach (var quantityString in _quantitiesToParse)
Expand Down
2 changes: 1 addition & 1 deletion UnitsNet.Benchmark/Conversions/FromString/QuantityFromUnitAbbreviationBenchmarks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace UnitsNet.Benchmark.Conversions.FromString;

[MemoryDiagnoser]
[SimpleJob(RuntimeMoniker.Net48)]
[SimpleJob(RuntimeMoniker.Net80)]
[SimpleJob(RuntimeMoniker.Net90)]
public class QuantityFromUnitAbbreviationBenchmarks
{
private static readonly CultureInfo Culture = CultureInfo.InvariantCulture;
Expand Down
2 changes: 1 addition & 1 deletion UnitsNet.Benchmark/Initializations/UnitAbbreviationsCacheInitializationBenchmarks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace UnitsNet.Benchmark.Initializations;

[MemoryDiagnoser]
[SimpleJob(RuntimeMoniker.Net48)]
[SimpleJob(RuntimeMoniker.Net80)]
[SimpleJob(RuntimeMoniker.Net90)]
public class UnitAbbreviationsCacheInitializationBenchmarks
{
[GlobalSetup]
Expand Down