refactor: Remove obsolete FromQuantityInfo method #1574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was just for backwards compatibility, I don't think this method was [Obsolete] in v5- so instead of breaking the build, i figured we'd issue a deprecation warning. But if you think we don't need it, I'm perfectly fine with it.. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1574 +/- ##
======================================
- Coverage 93% 93% -1%
======================================
Files 311 311
Lines 28781 28780 -1
======================================
- Hits 26864 26863 -1
Misses 1917 1917 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Let's remove stuff now that we have the chance in v6, I'd rather add it back if there was something we missed. |
|
Obsoleted in v5: #1577 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup of #1555