feat: Optimize CI/CD with Nano/Standard separation

[angularsen]

Implements optimized CI/CD workflows with separate Standard and Nano build targets.

Changes

• Separate Standard (Linux) and Nano (Windows) build targets
• Tests run on Linux for Standard builds
• Build and test steps separated for better visibility
• Each target publishes NuGets independently
• Added Linux/macOS build script

Closes #1628

Generated with Claude Code) | [View job](https://github.com/angularsen/UnitsNet/actions/runs/17896979138

[claude]

Pull Request Review

Summary

This PR implements an optimized CI/CD pipeline that separates Standard (Linux) and Nano (Windows) builds, running them in parallel for significant performance improvements. The changes are well-structured and follow good DevOps practices.

✅ Strengths

• Performance Optimization: ~40-50% faster builds through parallel execution and platform-specific optimizations
• Cost Reduction: ~30% reduction in GitHub Actions minutes by using Linux runners for Standard builds
• Clear Separation: Standard and Nano builds are properly isolated with appropriate platforms
• Backward Compatibility: Existing PowerShell scripts remain functional
• Good Documentation: Comprehensive guide with migration and rollback plans
• Safe Rollout Strategy: Workflows placed in 'proposed-workflows/' for testing before activation

📋 Observations

No Breaking Changes

✅ No breaking changes detected. The PR adds new CI/CD workflows and a build script without modifying existing functionality.

Style and Conventions

✅ The shell script follows Unix conventions with proper error handling (set -e)
✅ YAML workflows are well-structured with appropriate grouping and error handling
✅ Documentation is clear and includes helpful diagrams

Code Quality

✅ Good error handling in both bash and PowerShell scripts
✅ Proper use of environment variables and script paths
✅ Clean separation of concerns between Standard and Nano builds

Test Coverage

✅ Tests are properly executed in the Standard build job
✅ Test results are uploaded as artifacts for debugging
✅ Coverage is collected and uploaded to Codecov

🔍 Minor Suggestions

1. Build Script Permissions: The build.sh script will need executable permissions:
   chmod +x build.sh

2. Script Directory Logic: The line 'cd "$SCRIPT_DIR/.."' in build.sh:14 seems incorrect since the script is already in the root directory. Should be:
   cd "$SCRIPT_DIR"

3. Workflow Migration: Consider adding a temporary GitHub Actions workflow that runs both old and new workflows in parallel during the testing phase for direct comparison.

✅ Verdict

Approved with minor suggestions. This is a well-thought-out optimization that will significantly improve build times and reduce costs. The phased rollout approach minimizes risk, and the documentation is excellent.

The separation of Standard and Nano builds makes sense given their different platform requirements, and running them in parallel is a smart optimization. The preservation of existing scripts ensures developers can continue working without disruption.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96%. Comparing base (bde4d1a) to head (c100098).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #1630     +/-   ##
========================================
  Coverage      96%     96%             
========================================
  Files         322     450    +128     
  Lines       27404   29103   +1699     
========================================
+ Hits        26363   28062   +1699     
  Misses       1041    1041             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[claude]

Code Review: CI/CD Optimization with Nano/Standard Separation

Summary

This PR implements a well-thought-out optimization of the CI/CD pipeline by separating Standard and NanoFramework builds. The changes provide significant performance improvements (~40-50% faster builds) and cost reduction through platform-specific optimizations.

Strengths

• Parallel execution: Standard (Linux) and Nano (Windows) builds run concurrently, maximizing efficiency
• Platform optimization: Linux for Standard builds (faster/cheaper), Windows for Nano (required by MSBuild)
• Improved visibility: Separated build and test steps provide better time tracking and logging
• Cross-platform build script: New build.sh enables local builds on Linux/macOS
• Comprehensive documentation: CI-OPTIMIZATION-GUIDE.md provides clear migration path and architecture overview

Observations & Suggestions

1. No Breaking Changes - The changes are backward compatible and maintain existing functionality while improving performance.

2. Style and Conventions - Workflow files follow GitHub Actions best practices. Build script follows Unix conventions with proper error handling. PowerShell sections use idiomatic error handling patterns.

3. Version Inconsistency - The workflow files have inconsistent .NET SDK versions: .github/workflows/ci.yml uses .NET 6.0.x and 9.0.x while proposed-workflows/ci-optimized.yml uses .NET 6.0.x and 8.0.x. Consider aligning these versions for consistency.

4. NuGet Publishing Strategy - The PR implements immediate per-target publishing which could lead to partial releases if one target fails. Consider whether you want to wait for both targets to succeed before publishing any packages.

5. Test Coverage - Test coverage remains comprehensive with proper CodeCov integration for Standard builds. Note that Nano builds don't run tests (as expected for embedded targets).

6. Build Script Permissions - The new build.sh file will need execute permissions set: chmod +x build.sh

Minor Improvements

• The check-status job could provide more actionable error messages when builds fail
• Consider adding timestamps or commit SHAs to artifact names for better traceability
• Add a note in PR description about manually moving proposed-workflows files

Verdict

This is a high-quality optimization that maintains backward compatibility while providing substantial performance improvements. The separation of concerns between Standard and Nano builds is clean and well-executed. After addressing the minor version inconsistency, this PR is ready to merge.

Great work on the comprehensive testing approach and documentation!