Merged
Conversation
anhosh
approved these changes
Aug 24, 2025
Owner
anhosh
left a comment
anhosh
left a comment
There was a problem hiding this comment.
thank you so much for addressing this!
Contributor
Author
|
Super glad to see it merged. Thanks! Pozdrowienia :) |
Owner
|
Dzięki, również pozdrawiam :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solving #285
While rendering tab bar body I return
tab_hoveredfromtabsfunction so it can be passed totab_bar_scrollthat handles scrolling. Thanks to that scroll event is handled when pointer points over tab body, while other events like drag and click are still handled properly on particular tabs.I believe this is not a breaking change, just a minor fix, so I created PR directly to
main. Looking at the code I assume that scroll was supposed to work this way from the beginning.