Skip to content

Commit 6593d22

Browse files
authored
Merge pull request #173 from ani-team/fix/test-revisions
fix(revisions)/small fixes
2 parents aad288c + 312c26a commit 6593d22

File tree

8 files changed

+35
-18
lines changed

8 files changed

+35
-18
lines changed

src/app/header/index.tsx

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,20 @@ const Header = () => {
6666
onKeyDown={handleKeyDown}
6767
/>
6868
)}
69-
<a className="m-4 text-gray-600" href={GITHUB_MAIN}>
69+
<a
70+
className="m-4 text-gray-600"
71+
href={GITHUB_MAIN}
72+
target="_blank"
73+
rel="noopener noreferrer"
74+
>
7075
GitHub
7176
</a>
72-
<a className="m-4 text-gray-600" href={GITHUB_FEEDBACK}>
77+
<a
78+
className="m-4 text-gray-600"
79+
href={GITHUB_FEEDBACK}
80+
target="_blank"
81+
rel="noopener noreferrer"
82+
>
7383
Feedback
7484
</a>
7585
</div>

src/features/repo-list/index.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
margin-left: 38px;
33

44
&__placeholder {
5-
margin: 20px 0;
5+
margin: 30px 0;
66
text-align: center;
77
}
88

src/features/repo-list/index.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import React from "react";
2+
import { Empty } from "antd";
23
import { Repo, Tabs, SimplePagination, Card } from "shared/components";
34
import { str, dom } from "shared/helpers";
45
import { useReposQuery } from "./queries.gen";
@@ -52,9 +53,10 @@ const RepoList = ({ username }: Props) => {
5253
/>
5354
))
5455
) : (
55-
<h2 className="repo-list__placeholder">
56-
{username} doesn’t have any repositories yet.
57-
</h2>
56+
<Empty
57+
className="repo-list__placeholder"
58+
description={<h2>{username} doesn’t have any repositories yet.</h2>}
59+
/>
5860
)}
5961
</div>
6062
<div className="repo-list__pagination mt-6">

src/features/user-info/index.scss

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,9 @@
3333
line-height: 28px;
3434
}
3535

36-
&__btn.follow,
37-
&__btn.unfollow,
38-
&__btn.edit {
36+
&__btn {
37+
display: block !important;
3938
margin-top: 10px;
4039
transition: 0.4s;
41-
42-
&:hover {
43-
cursor: pointer;
44-
}
4540
}
4641
}

src/features/user-info/index.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,14 @@ const UserInfo = ({ username }: Props) => {
3232
<h1 className="user-info__name">{name}</h1>
3333
<h4 className="user-info__username">{username}</h4>
3434
<span className="user-info__bio">{bio}</span>
35-
<br></br>
3635
{isViewer ? (
37-
<Button className="user-info__btn edit" disabled title="While not available">
36+
<Button className="user-info__btn" disabled title="While not available">
3837
Edit profile
3938
</Button>
4039
) : (
4140
<Button
4241
type={viewerIsFollowing ? "primary" : "default"}
43-
className={`user-info__btn ${label}`}
42+
className="user-info__btn"
4443
onClick={() => following.handle(id, viewerIsFollowing)}
4544
loading={following.debouncedLodaing}
4645
>

src/pages/user/index.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
.page-user {
2+
padding: 0 20px;
23
margin: 40px 10% !important;
34
}

src/shared/components/simple-pagination/index.scss

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,14 @@
22
&.center {
33
text-align: center;
44
}
5+
6+
.prev-btn {
7+
border-top-right-radius: 0 !important;
8+
border-bottom-right-radius: 0 !important;
9+
}
10+
11+
.next-btn {
12+
border-top-left-radius: 0 !important;
13+
border-bottom-left-radius: 0 !important;
14+
}
515
}

src/shared/components/simple-pagination/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ const SimplePagination = (props: Props) => {
2626
return (
2727
<div className={cn("simple-pagination", { center })}>
2828
<Button.Group>
29-
<Button disabled={!hasPrevPage} onClick={onPrev}>
29+
<Button className="prev-btn" disabled={!hasPrevPage} onClick={onPrev}>
3030
<LeftOutlined /> Prev
3131
</Button>
32-
<Button disabled={!hasNextPage} onClick={onNext}>
32+
<Button className="next-btn" disabled={!hasNextPage} onClick={onNext}>
3333
Next <RightOutlined />
3434
</Button>
3535
</Button.Group>

0 commit comments

Comments
 (0)