Skip to content

Allow to pass multiple lib dirs split by a colon #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow to pass multiple lib dirs split by a colon #61

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9a37a6
Allow to pass multiple lib dirs split by a colon
alvaromat Aug 5, 2024
4035081
Clean up
alvaromat Aug 6, 2024
ab867a8
Fix library not linking
alvaromat Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions ext/or-tools/extconf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,20 @@
if inc || lib
inc ||= "/usr/local/include"
lib ||= "/usr/local/lib"
rpath = lib

lib_dirs = lib.split(':')
rpath = lib_dirs.join(':')

# Find the first lib directory containing libprotobuf.a
libprotobuf_dir = lib_dirs.find { |dir| File.exist?("#{dir}/libprotobuf.a") }
raise "libprotobuf.a not found" unless libprotobuf_dir

# -L flags for each lib directory
lib_dirs_flags = lib_dirs.map { |lib_dir| "-L#{lib_dir} " }.join

$INCFLAGS << " -I#{inc}"
ld_flags = "-Wl,-rpath,#{rpath} #{lib_dirs_flags} #{libprotobuf_dir}/libprotobuf.a "
$LDFLAGS.prepend(ld_flags)
else
# download
require_relative "vendor"
Expand All @@ -21,15 +34,10 @@
# use double dollar sign and single quotes to escape properly
rpath_prefix = RbConfig::CONFIG["host_os"] =~ /darwin/ ? "@loader_path" : "$$ORIGIN"
rpath = "'#{rpath_prefix}/../../tmp/or-tools/lib'"

$INCFLAGS << " -I#{inc}"
$LDFLAGS.prepend("-Wl,-rpath,#{rpath} -L#{lib} #{lib}/libprotobuf.a ")
end

# find_header and find_library first check without adding path
# which can cause them to find system library
$INCFLAGS << " -I#{inc}"
# could support shared libraries for protobuf and abseil
# but keep simple for now
raise "libprotobuf.a not found" unless File.exist?("#{lib}/libprotobuf.a")
$LDFLAGS.prepend("-Wl,-rpath,#{rpath} -L#{lib} #{lib}/libprotobuf.a ")
raise "OR-Tools not found" unless have_library("ortools")

create_makefile("or_tools/ext")