Fix: scrollThreshold is not properly applied in inverse mode#382
Open
oscar60310 wants to merge 1 commit intoankeetmaini:masterfrom
Open
Fix: scrollThreshold is not properly applied in inverse mode#382oscar60310 wants to merge 1 commit intoankeetmaini:masterfrom
oscar60310 wants to merge 1 commit intoankeetmaini:masterfrom
Conversation
|
@oscar60310 Any update on this? |
Author
|
Hi, the fix should work, but the project seems to be inactive. Therefore, I have duplicated the code into our project instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's happened
In inverse mode,
scrollThresholdwas not properly applied, so we needed to scroll to the end to triggernextfunction calls.before.mp4
Solution
We should multiply it with
scrollHeightas we did in normal mode.after.mp4