Skip to content

Revert "test: Android 36+ emulators built-in sqlite responds w/new exception #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-allison merged 1 commit into from
Jan 6, 2026
Merged

Revert "test: Android 36+ emulators built-in sqlite responds w/new exception #627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 12 additions & 30 deletions ...rumented/src/androidTest/java/net/ankiweb/rsdroid/database/CorruptDiskFullDatabaseTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@
*/
package net.ankiweb.rsdroid.database

import android.database.sqlite.SQLiteDiskIOException
import android.database.sqlite.SQLiteFullException
import android.os.Build
import net.ankiweb.rsdroid.database.testutils.DatabaseCorruption
import net.ankiweb.rsdroid.exceptions.BackendJsonException
import org.hamcrest.MatcherAssert
Expand All @@ -44,35 +42,19 @@ class CorruptDiskFullDatabaseTest : DatabaseCorruption() {
)
}
DatabaseType.FRAMEWORK -> {
// FRAMEWORK still complains about disk full corruption for API < 36:
// FRAMEWORK still complains about disk full corruption:
// error while compiling: "create table nums (id int)": DBError { info: "SqliteFailure(Error { code: DiskFull, extended_code: 13 }, Some(\"database or disk is full\"))", kind: Other }
if (Build.VERSION.SDK_INT_FULL < Build.VERSION_CODES_FULL.BAKLAVA) {
MatcherAssert.assertThat(
setupException.javaClass,
Matchers.typeCompatibleWith(
SQLiteFullException::class.java,
),
)
// Java: "database or disk is full (code 13)"
MatcherAssert.assertThat(
setupException.localizedMessage,
Matchers.containsString("database or disk is full"),
)
// On API >= 36 we get a disk I/O exception
} else {
MatcherAssert.assertThat(
setupException.javaClass,
Matchers.typeCompatibleWith(
SQLiteDiskIOException::class.java,
),
)

// Java: "database or disk is full (code 13)"
MatcherAssert.assertThat(
setupException.localizedMessage,
Matchers.containsString("disk I/O error"),
)
}
MatcherAssert.assertThat(
setupException.javaClass,
Matchers.typeCompatibleWith(
SQLiteFullException::class.java,
),
)
// Java: "database or disk is full (code 13)"
MatcherAssert.assertThat(
setupException.localizedMessage,
Matchers.containsString("database or disk is full"),
)
}
else -> null
}
Expand Down