perf: improve tags dialog initialization

Author: BrayanDSO

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.kt

@@ -2619,12 +2619,11 @@ abstract class AbstractFlashcardViewer :
         get() = displayAnswer
 
     internal fun showTagsDialog() {
-        val tags = ArrayList(getColUnsafe.tags.all())
-        val selTags = ArrayList(currentCard!!.note(getColUnsafe).tags)
+        val noteId = currentCard!!.note(getColUnsafe).id
         val dialog =
             tagsDialogFactory!!
                 .newTagsDialog()
-                .withArguments(this, TagsDialog.DialogType.EDIT_TAGS, selTags, tags)
+                .withArguments(this, TagsDialog.DialogType.EDIT_TAGS, noteIds = listOf(noteId))
         showDialogFragment(dialog)
     }
 

AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.kt

@@ -121,7 +121,6 @@ import com.ichi2.libanki.ChangeManager
 import com.ichi2.libanki.Collection
 import com.ichi2.libanki.DeckId
 import com.ichi2.libanki.DeckNameId
-import com.ichi2.libanki.NoteId
 import com.ichi2.libanki.SortOrder
 import com.ichi2.libanki.undoableOp
 import com.ichi2.ui.CardBrowserSearchView
@@ -131,10 +130,8 @@ import com.ichi2.utils.dp
 import com.ichi2.utils.increaseHorizontalPaddingOfOverflowMenuIcons
 import com.ichi2.utils.updatePaddingRelative
 import com.ichi2.widget.WidgetStatus.updateInBackground
-import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.Job
 import kotlinx.coroutines.launch
-import kotlinx.coroutines.withContext
 import net.ankiweb.rsdroid.RustCleanup
 import net.ankiweb.rsdroid.Translations
 import timber.log.Timber
@@ -1547,84 +1544,16 @@ open class CardBrowser :
         if (!viewModel.hasSelectedAnyRows()) {
             Timber.d("showEditTagsDialog: called with empty selection")
         }
-
-        var progressMax: Int? = null // this can be made null to blank the dialog
-        var progress = 0
-
-        fun onProgress(progressContext: ProgressContext) {
-            val max = progressMax
-            if (max == null) {
-                progressContext.amount = null
-                progressContext.text = getString(R.string.dialog_processing)
-            } else {
-                progressContext.amount = Pair(progress, max)
-            }
-        }
-        launchCatchingTask {
-            withProgress(extractProgress = ::onProgress) {
-                val allTags = withCol { tags.all() }
-                val selectedNoteIds = viewModel.queryAllSelectedNoteIds()
-
-                progressMax = selectedNoteIds.size * 2
-                // TODO!! This is terribly slow on AnKing
-                val checkedTags =
-                    withCol {
-                        selectedNoteIds
-                            .asSequence() // reduce memory pressure
-                            .flatMap { nid ->
-                                progress++
-                                getNote(nid).tags // requires withCol
-                            }.distinct()
-                            .toList()
-                    }
-
-                if (selectedNoteIds.size == 1) {
-                    Timber.d("showEditTagsDialog: edit tags for one note")
-                    tagsDialogListenerAction = TagsDialogListenerAction.EDIT_TAGS
-                    val dialog =
-                        tagsDialogFactory.newTagsDialog().withArguments(
-                            this@CardBrowser,
-                            type = TagsDialog.DialogType.EDIT_TAGS,
-                            checkedTags = checkedTags,
-                            allTags = allTags,
-                        )
-                    showDialogFragment(dialog)
-                    return@withProgress
-                }
-                // TODO!! This is terribly slow on AnKing
-                // PERF: This MUST be combined with the above sequence - this becomes O(2n) on a
-                // database operation performed over 30k times
-                val uncheckedTags =
-                    withCol {
-                        selectedNoteIds
-                            .asSequence() // reduce memory pressure
-                            .flatMap { nid: NoteId ->
-                                progress++
-                                val note = getNote(nid) // requires withCol
-                                val noteTags = note.tags.toSet()
-                                allTags.filter { t: String? -> !noteTags.contains(t) }
-                            }.distinct()
-                            .toList()
-                    }
-
-                progressMax = null
-
-                Timber.d("showEditTagsDialog: edit tags for multiple note")
-                tagsDialogListenerAction = TagsDialogListenerAction.EDIT_TAGS
-
-                // withArguments performs IO, can be 18 seconds
-                val dialog =
-                    withContext(Dispatchers.IO) {
-                        tagsDialogFactory.newTagsDialog().withArguments(
-                            context = this@CardBrowser,
-                            type = TagsDialog.DialogType.EDIT_TAGS,
-                            checkedTags = checkedTags,
-                            uncheckedTags = uncheckedTags,
-                            allTags = allTags,
-                        )
-                    }
-                showDialogFragment(dialog)
-            }
+        tagsDialogListenerAction = TagsDialogListenerAction.EDIT_TAGS
+        lifecycleScope.launch {
+            val noteIds = viewModel.queryAllSelectedNoteIds()
+            val dialog =
+                tagsDialogFactory.newTagsDialog().withArguments(
+                    this@CardBrowser,
+                    type = TagsDialog.DialogType.EDIT_TAGS,
+                    noteIds = noteIds,
+                )
+            showDialogFragment(dialog)
         }
     }
 
@@ -1635,8 +1564,7 @@ open class CardBrowser :
                 tagsDialogFactory.newTagsDialog().withArguments(
                     context = this@CardBrowser,
                     type = TagsDialog.DialogType.FILTER_BY_TAG,
-                    checkedTags = ArrayList(0),
-                    allTags = withCol { tags.all() },
+                    noteIds = emptyList(),
                 )
             showDialogFragment(dialog)
         }

AnkiDroid/src/main/java/com/ichi2/anki/NoteEditor.kt

@@ -1605,18 +1605,13 @@ class NoteEditor :
     }
 
     private fun showTagsDialog() {
-        if (selectedTags == null) {
-            selectedTags = ArrayList(0)
-        }
-        val tags = ArrayList(getColUnsafe.tags.all())
-        val selTags = ArrayList(selectedTags!!)
+        val selTags = selectedTags?.let { ArrayList(it) } ?: arrayListOf()
         val dialog =
             with(requireContext()) {
                 tagsDialogFactory!!.newTagsDialog().withArguments(
                     context = this,
                     type = TagsDialog.DialogType.EDIT_TAGS,
                     checkedTags = selTags,
-                    allTags = tags,
                 )
             }
         showDialogFragment(dialog)