fix: reminder question time elapsed by gayatriii0803 · Pull Request #17774 · ankidroid/Anki-Android

gayatriii0803 · 2025-01-09T04:19:57Z

Purpose / Description

Auto Advance "Question time elapsed" reminder does not work

Fixes

Fixes Auto Advance "Question time elapsed" reminder does not work #17765

Approach

show snackbar on automaticShowAnswer()

How Has This Been Tested?

Physical device (OPPO F21 Pro 5G).

Checklist

Please, go through these checks before submitting the PR.

You have a descriptive commit message with a short title (first line, max 50 chars).
You have commented your code, particularly in hard-to-understand areas
You have performed a self-review of your own code
UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
UI Changes: You have tested your change using the Google Accessibility Scanner

gayatriii0803 · 2025-01-09T17:55:26Z

I don't understand why this fails. Is this related to my code?

mikehardy · 2025-01-09T18:27:39Z

@gayatriii0803 failure most likely unrelated:

Triggered via pull request 11 hours ago

Github blew up

https://www.githubstatus.com/incidents/l76qh74ryp16

mikehardy · 2025-01-09T18:28:03Z

Closing and reopening forces a CI re-run.

fixed

BrayanDSO

Lint and tests are failing

gayatriii0803 · 2025-01-10T10:32:36Z

AutomaticAnswerActionTest > testExecute FAILED
    java.lang.UnsatisfiedLinkError: 'byte[][] net.ankiweb.rsdroid.NativeMethods.openBackend(byte[])'
        at net.ankiweb.rsdroid.NativeMethods.openBackend(Native Method)
        at net.ankiweb.rsdroid.Backend.<init>(Backend.kt:79)
        at net.ankiweb.rsdroid.BackendFactory.getBackend(BackendFactory.kt:39)
        at net.ankiweb.rsdroid.BackendFactory.getBackend$default(BackendFactory.kt:35)
        at com.ichi2.anki.CollectionManager.ensureBackendInner(CollectionManager.kt:208)
        at com.ichi2.anki.CollectionManager.access$ensureBackendInner(CollectionManager.kt:41)
        at com.ichi2.anki.CollectionManager$getBackend$1.invokeSuspend$lambda$0(CollectionManager.kt:153)
        at com.ichi2.anki.CollectionManager$withQueue$3.invokeSuspend(CollectionManager.kt:105)
        at _COROUTINE._BOUNDARY._(CoroutineDebugging.kt:42)
        at com.ichi2.anki.CollectionManager$getBackend$1.invokeSuspend(CollectionManager.kt:153)

Can anyone help me here?

mikehardy · 2025-01-10T13:44:42Z

@david-allison - the test using TR.... which means it needs the backend. Is @JvmTest the correct inheritance there? Or should it be `RobolectricTest ?

david-allison · 2025-01-10T14:12:13Z

JVM - the backend shouldn't need an Android dependency

github-actions · 2025-01-24T14:37:28Z

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

BrayanDSO · 2025-02-07T22:50:14Z

AnkiDroid/src/test/java/com/ichi2/anki/reviewer/AutomaticAnswerActionTest.kt

-    @Test
-    fun fromPreferenceValue() {
+@RunWith(AndroidJUnit4::class)
+class AutomaticAnswerActionTest : RobolectricTest() {


why do you need robolectric here? You can use a generic message instead of TR. below

david-allison

I don't understand the context of the bug from this PR

Could the commit message be updated to give a very brief explanation of the issue and the fix

mikehardy

seems like it's good to go but agreed, the PR description doesn't really say why it wasn't working before and why the PR fixes it, and the comment doesn't either.

Both should have some sort of <feature> wasn't working because of <reason>, this PR solves it by <approach> so that future people know what is going on

I can't really merge it without feeling like I know what is going on

BrayanDSO

I tested that on the new reviewer instead of the old one 🙈, and I already added that reminder since the implementation of Auto Advance there. Shame on me.

Your PR mistakenly uses the same action of the answer

BrayanDSO · 2025-02-20T09:55:24Z

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/autoadvance/QuestionAction.kt

+    fun execute(reviewer: Reviewer) {
+        val action = this.toCommand()
+        if (action != null) {
+            Timber.i("Executing %s", action)
+            reviewer.executeCommand(action)
+        } else {
+            reviewer.showSnackbar(TR.studyingQuestionTimeElapsed())
+        }
+    }
+
+    /** Convert to a [ViewerCommand] */
+    private fun toCommand(): ViewerCommand? =
+        when (this) {
+            SHOW_ANSWER -> ViewerCommand.SHOW_ANSWER
+            SHOW_REMINDER -> null
+        }
+


this couples the class to the old reviewer, which is bad by itself as code design, and the old reviewer will be removed eventually. Please do these changes on Reviewer or extensions methods there, but not here.

github-actions · 2025-03-11T18:41:33Z

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

github-actions · 2025-04-01T00:53:54Z

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

lukstbit added the Needs Author Reply Waiting for a reply from the original author label Jan 9, 2025

gayatriii0803 force-pushed the reminder branch from 2edd15d to 447cd4d Compare January 9, 2025 07:27

mikehardy closed this Jan 9, 2025

mikehardy reopened this Jan 9, 2025

This comment was marked as resolved.

Sign in to view

gayatriii0803 force-pushed the reminder branch from 447cd4d to 6bcda80 Compare January 10, 2025 03:10

david-allison added Needs Review and removed Needs Author Reply Waiting for a reply from the original author labels Jan 10, 2025

BrayanDSO reviewed Jan 10, 2025

View reviewed changes

BrayanDSO added Needs Author Reply Waiting for a reply from the original author and removed Needs Review labels Jan 10, 2025

gayatriii0803 force-pushed the reminder branch from 6bcda80 to f8c5f92 Compare January 10, 2025 09:36

github-actions bot added the Stale label Jan 24, 2025

github-actions bot closed this Jan 31, 2025

sanjaysargam reopened this Feb 4, 2025

github-actions bot removed the Stale label Feb 4, 2025

gayatriii0803 force-pushed the reminder branch from f8c5f92 to 9c33827 Compare February 4, 2025 15:29

sanjaysargam added Needs Review and removed Needs Author Reply Waiting for a reply from the original author labels Feb 4, 2025

gayatriii0803 requested a review from BrayanDSO February 5, 2025 09:52

BrayanDSO requested changes Feb 7, 2025

View reviewed changes

BrayanDSO added the Needs Author Reply Waiting for a reply from the original author label Feb 7, 2025

BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author Needs Review labels Feb 8, 2025

david-allison requested changes Feb 8, 2025

View reviewed changes

david-allison added the Needs Author Reply Waiting for a reply from the original author label Feb 8, 2025

mikehardy requested changes Feb 10, 2025

View reviewed changes

BrayanDSO requested changes Feb 10, 2025

View reviewed changes

BrayanDSO removed the Needs Second Approval Has one approval, one more approval to merge label Feb 10, 2025

gayatriii0803 force-pushed the reminder branch from 87db28a to 9fc8155 Compare February 18, 2025 11:06

github-actions bot added the Has Conflicts label Feb 18, 2025

gayatriii0803 force-pushed the reminder branch 2 times, most recently from 9fc8155 to c58c164 Compare February 19, 2025 06:56

gayatriii0803 requested a review from BrayanDSO February 19, 2025 06:56

gayatriii0803 force-pushed the reminder branch from c58c164 to 0ac44b0 Compare February 19, 2025 07:14

sanjaysargam added Needs Review and removed Needs Author Reply Waiting for a reply from the original author Has Conflicts labels Feb 20, 2025

BrayanDSO requested changes Feb 20, 2025

View reviewed changes

BrayanDSO added Needs Author Reply Waiting for a reply from the original author and removed Needs Review labels Feb 20, 2025

fix: reminder question time elapsed

fb9d055

gayatriii0803 force-pushed the reminder branch from 0ac44b0 to fb9d055 Compare February 25, 2025 16:19

gayatriii0803 requested a review from BrayanDSO February 25, 2025 18:29

github-actions bot added Stale Has Conflicts and removed Stale labels Mar 11, 2025

github-actions bot added the Stale label Apr 1, 2025

github-actions bot closed this Apr 8, 2025

Uh oh!

Conversation

gayatriii0803 commented Jan 9, 2025

Purpose / Description

Fixes

Approach

How Has This Been Tested?

Checklist

Uh oh!

gayatriii0803 commented Jan 9, 2025

Uh oh!

mikehardy commented Jan 9, 2025

Uh oh!

mikehardy commented Jan 9, 2025

Uh oh!

This comment was marked as resolved.

Uh oh!

BrayanDSO left a comment

Choose a reason for hiding this comment

Uh oh!

gayatriii0803 commented Jan 10, 2025

Uh oh!

mikehardy commented Jan 10, 2025

Uh oh!

david-allison commented Jan 10, 2025

Uh oh!

github-actions bot commented Jan 24, 2025

Uh oh!

BrayanDSO Feb 7, 2025

Choose a reason for hiding this comment

Uh oh!

david-allison left a comment

Choose a reason for hiding this comment

Uh oh!

mikehardy left a comment

Choose a reason for hiding this comment

Uh oh!

BrayanDSO left a comment

Choose a reason for hiding this comment

Uh oh!

BrayanDSO Feb 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 11, 2025

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants