Fixed bug which was causing AnkiDroid API to not list media on cards. by ujjol1234 · Pull Request #17859 · ankidroid/Anki-Android

ujjol1234 · 2025-01-22T19:34:05Z

Purpose / Description

Fixed the bug which was causing AnkiDroid API to not list media on cards. Added a unit test to confirm that media files are listed correctly in the ReviewInfo.

Fixes

Fixes [BUG] AnkiDroid API no longer lists media on cards #17062

Approach

Reimplemented the filesinStr function which was causing the bug.

How Has This Been Tested?

A unit test testMediaFilesAddedCorrectlyInReviewInfo() has been added in the ContentProviderTest.kt to confirm that the MEDIA_FILES attribute of ReviewInfo gets populated correctly.

Checklist

Please, go through these checks before submitting the PR.

You have a descriptive commit message with a short title (first line, max 50 chars).
You have commented your code, particularly in hard-to-understand areas
You have performed a self-review of your own code
UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
UI Changes: You have tested your change using the Google Accessibility Scanner

welcome · 2025-01-22T19:34:08Z

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

AnkiDroid/src/main/java/com/ichi2/libanki/Media.kt

AnkiDroid/src/androidTest/java/com/ichi2/anki/tests/ContentProviderTest.kt

github-actions · 2025-02-28T16:40:28Z

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

mikehardy · 2025-04-02T12:08:21Z

I feel like we were close here but both David and I have been really busy, apologies for the default-stale-close
Will reopen to give another chance for @ujjol1234 to advance the comments under discussion

david-allison

I have force pushed this and feel it's ready for review

ujjol1234 · 2025-06-09T16:34:34Z

Hi @david-allison, apologies for the delayed response — I had semester exams going on. I’m back now and will be able to contribute consistently moving forward!

david-allison · 2025-06-09T16:38:49Z

No worries! I've taken this to the finish line and added a decent amount more issues

Thanks so much for the hard work here

Fixed bug which was causing AnkiDroid API to not list media on cards. Due to card rendering being moved to the backend, and Anki using different Regex handling code, we needed to change the implementation of `files_in_str`: [sound:] tags were stripped, for example https://github.com/ankitects/anki/blob/64ca90934bc26ddf7125913abc9dd9de8cb30c2b/pylib/anki/media.py#L136-L150 Fixes 17062

mikehardy

Not going to second-guess your work here, let's get this in and we can do follow-ons as needed. Will pick to 2.21 branch so it'll hit the next release

github-actions bot added the New contributor label Jan 22, 2025

ujjol1234 mentioned this pull request Jan 22, 2025

[BUG] AnkiDroid API no longer lists media on cards #17062

Closed

david-allison reviewed Jan 22, 2025

View reviewed changes

AnkiDroid/src/main/java/com/ichi2/libanki/Media.kt Outdated Show resolved Hide resolved

lukstbit added the Needs Author Reply Waiting for a reply from the original author label Jan 23, 2025

david-allison reviewed Jan 27, 2025

View reviewed changes

AnkiDroid/src/androidTest/java/com/ichi2/anki/tests/ContentProviderTest.kt Show resolved Hide resolved

github-actions bot added the Stale label Feb 28, 2025

github-actions bot closed this Mar 7, 2025

mikehardy reopened this Apr 2, 2025

github-actions bot removed the Stale label Apr 2, 2025

This comment has been minimized.

Sign in to view

github-actions bot added Stale and removed Stale labels Apr 16, 2025

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

github-actions bot added the Stale label May 5, 2025

github-actions bot closed this May 12, 2025

david-allison added the Needs a new dev For PR that were good start but the original dev' left. Any dev can take over and finish it. label Jun 3, 2025

david-allison reopened this Jun 3, 2025

github-actions bot added Has Conflicts and removed Stale labels Jun 3, 2025

david-allison force-pushed the filesinStr-BUG-Fix branch from 47b50bb to c84f993 Compare June 9, 2025 00:00

david-allison removed Needs Author Reply Waiting for a reply from the original author Needs a new dev For PR that were good start but the original dev' left. Any dev can take over and finish it. Has Conflicts labels Jun 9, 2025

david-allison reviewed Jun 9, 2025

View reviewed changes

david-allison added API Needs Review labels Jun 9, 2025

david-allison force-pushed the filesinStr-BUG-Fix branch from c84f993 to d442c1b Compare June 9, 2025 16:17

github-actions bot added the Has Conflicts label Jun 10, 2025

david-allison force-pushed the filesinStr-BUG-Fix branch from d442c1b to 2553ff9 Compare June 17, 2025 12:27

david-allison removed the Has Conflicts label Jun 17, 2025

david-allison added this to the 2.21 release milestone Jun 17, 2025

github-actions bot added the Has Conflicts label Jun 18, 2025

david-allison force-pushed the filesinStr-BUG-Fix branch from 2553ff9 to f067bf9 Compare June 23, 2025 17:03

david-allison force-pushed the filesinStr-BUG-Fix branch from f067bf9 to 7978e17 Compare June 24, 2025 13:39

david-allison added Queued for Cherry Pick to Stable Branch and removed Has Conflicts labels Jun 24, 2025

mikehardy approved these changes Jun 25, 2025

View reviewed changes

mikehardy added this pull request to the merge queue Jun 25, 2025

mikehardy added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Jun 25, 2025

Merged via the queue into ankidroid:main with commit e8dce4e Jun 25, 2025
9 checks passed

github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jun 25, 2025

mikehardy added Cherry Picked to Stable Branch and removed Queued for Cherry Pick to Stable Branch labels Jun 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed bug which was causing AnkiDroid API to not list media on cards.#17859

Fixed bug which was causing AnkiDroid API to not list media on cards.#17859
mikehardy merged 1 commit intoankidroid:mainfrom
ujjol1234:filesinStr-BUG-Fix

ujjol1234 commented Jan 22, 2025

Uh oh!

welcome bot commented Jan 22, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 28, 2025

Uh oh!

mikehardy commented Apr 2, 2025

Uh oh!

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as resolved.

david-allison left a comment

Uh oh!

ujjol1234 commented Jun 9, 2025

Uh oh!

david-allison commented Jun 9, 2025

Uh oh!

mikehardy left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ujjol1234 commented Jan 22, 2025

Purpose / Description

Fixes

Approach

How Has This Been Tested?

Checklist

Uh oh!

welcome bot commented Jan 22, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 28, 2025

Uh oh!

mikehardy commented Apr 2, 2025

Uh oh!

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as resolved.

david-allison left a comment

Choose a reason for hiding this comment

Uh oh!

ujjol1234 commented Jun 9, 2025

Uh oh!

david-allison commented Jun 9, 2025

Uh oh!

mikehardy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants