Skip to content

Fixes #17864 : Instant card, Double Pop of Discard Dialog Box issue #17871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MritunjayTiwari14 wants to merge 7 commits into from
Closed

Fixes #17864 : Instant card, Double Pop of Discard Dialog Box issue #17871

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3e25c58
Fixes #17864 : Instant card, Double Pop of Discard Dialog Box issue
MritunjayTiwari14 Jan 25, 2025
1589b61
Removed the Unneccesary Comments
MritunjayTiwari14 Feb 4, 2025
34a3549
Fixed Double Pop up using Dismiss Listener and Setted Cancellable to …
MritunjayTiwari14 Feb 6, 2025
0bc022c
Removed Comments
MritunjayTiwari14 Feb 8, 2025
b378121
Removed SetCancelable from DiscardChangeDialog.kt and Added into Acti…
MritunjayTiwari14 Feb 8, 2025
e9f193d
Removed Use of Flag to Track Multiple Dialog
MritunjayTiwari14 Feb 9, 2025
42d6845
Reverted all the Old Changes and Applied the New Once
MritunjayTiwari14 Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions AnkiDroid/src/main/java/com/ichi2/anki/instantnoteeditor/InstantNoteEditorActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,14 @@ class InstantNoteEditorActivity :
private val clozeFieldText: String?
get() = viewModel.actualClozeFieldText.value

private var isDialogVisible = false

private val dialogBackCallback =
object : OnBackPressedCallback(false) {
override fun handleOnBackPressed() {
showDiscardChangesDialog()
if (!isDialogVisible) {
showDiscardChangesDialog()
}
}
}

Expand Down Expand Up @@ -600,10 +604,17 @@ class InstantNoteEditorActivity :
}

private fun showDiscardChangesDialog() {
DiscardChangesDialog.showDialog(this) {
Timber.i("InstantNoteEditorActivity:: OK button pressed to confirm discard changes")
finish()
}
DiscardChangesDialog
.showDialog(this) {
Timber.d("InstantNoteEditorActivity:: OK button pressed to confirm discard changes")
finish()
}.apply {
setCancelable(false)
setOnDismissListener {
isDialogVisible = false
}
}
isDialogVisible = true
}

private fun convertSelectedTextToCloze(
Expand Down