Skip to content

Fix: Card Browser Border and Header Height.#17904

Merged
david-allison merged 1 commit intoankidroid:mainfrom
argon2r:border
Feb 8, 2025
Merged

Fix: Card Browser Border and Header Height.#17904
david-allison merged 1 commit intoankidroid:mainfrom
argon2r:border

Conversation

@argon2r
Copy link
Copy Markdown
Contributor

@argon2r argon2r commented Jan 30, 2025

Purpose / Description

Fixed the Card Browser Border and Column Header Height.

Fixes

Approach

Created drawable file for the bottom divider to improve the Card Browser border, increased the Card Browser Header height and improved the heading text Alignment.

How Has This Been Tested?

State Screenshot
Before
After

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@brishtibheja
Copy link
Copy Markdown

From what I said in Discord: why is is the border between columns extending to the headers? The before images don't have that.

@argon2r
Copy link
Copy Markdown
Contributor Author

argon2r commented Jan 31, 2025

From what I said in Discord: why is is the border between columns extending to the headers? The before images don't have that.

As additional columns are added to the card browser, vertical lines enhance its organization and clarity.

@xenonnn4w xenonnn4w added the Needs Author Reply Waiting for a reply from the original author label Feb 2, 2025
@xenonnn4w xenonnn4w added Needs Review and removed Needs Author Reply Waiting for a reply from the original author labels Feb 2, 2025
@BrayanDSO BrayanDSO added Needs Author Reply Waiting for a reply from the original author and removed Needs Review labels Feb 7, 2025
Copy link
Copy Markdown
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author labels Feb 8, 2025
Copy link
Copy Markdown
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, cheers!

* The header is made taller to make it accessible as a tappable element
* The vertical border between columns is removed
  * There was design consensus that this looks better

Fixes 17894
Fixes 17896
@david-allison
Copy link
Copy Markdown
Member

Squashed & edited commit message

@david-allison david-allison added this pull request to the merge queue Feb 8, 2025
Merged via the queue into ankidroid:main with commit 7f20a0e Feb 8, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Feb 8, 2025
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Feb 8, 2025
@david-allison
Copy link
Copy Markdown
Member

Hi there @argon2r! This is the OpenCollective Notice for PRs merged from 2025-02-01 through 2025-02-28

If you are interested in compensation for this work, the process with details is here: https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Card browser: Increase Height of Column Headers Add border between column header and first row

5 participants