feat: WidgetSmall redesign non material you#17909
feat: WidgetSmall redesign non material you#17909Rdkang wants to merge 6 commits intoankidroid:mainfrom
Conversation
|
Also add the parameters |
|
I found that vector files aren't processed for (API<=31), so we have to make a separate drawable file with JPG type most prolly. I'll create a separate issue regarding this for both the widget small and add note. You may ignore my above comment for meanwhile. |
Thanks i didn't think about this before, I will implement this now :) |
This comment has been minimized.
This comment has been minimized.
|
This pull request is ready for a review (this also fixes a bug in #17654 where it shows two clock icons for the non dynamic widget) :) @david-allison I'll create a new pull request for the widget picker preview @xenonnn4w |
|
I admit I don't know this widget, so I don't know what exactly is expected. When are the two numbers expected to be displayed? Could you update the PR description to help the reviewer reproduce and check that the result obtained is similar to the expected result? |
Arthur-Milchior
left a comment
There was a problem hiding this comment.
Thank you very much for your contributions.
I admit I find thir PR very hard to review. XML is far harder to read than Kotlin, some changes seems to be small details.
I've no idea for example how come we had 4 images that were unused. If this is related to the remaining of your PR, I'd love to understand how it is related. If it's , as it appear, some very old code, then maybe a separate PR would be great, so that your already complex PR would be simpler to review.
If you have time to take a look at git blame and figure out why they were introduced and when they stopped being used it may be interesting. Even if, admittedly, I'm fine if you don't do it, as this seems it has not been used in quite a while. Last commit where I see "widget_bg_number" is 626d334, from 2015!
|
Or it seems I get it wrong. The images were used up until your second commit. |
@Rdkang |
design The pre-v31 and newer now use the same design apart from using static colors for pre-v31, so this code is now redundant.
Signed-off-by: Rdkang <68774237+Rdkang@users.noreply.github.com>
2fef8c2 to
9249df3
Compare
use `material_light_blue_700` color from the theme, ensuring consistency with the rest of the app's styling.


Purpose / Description
Update small widget design for SDK versions below v31 with the Material You design (using static, not dynamic, colors). This will improve design consistency and simplify the codebase.
Fixes
Approach
Updated the design
How Has This Been Tested?
Virtual pixel 3 on SDK 28 and pixel 7 on SDK 35
Checklist
Please, go through these checks before submitting the PR.