feat(new reviewer): tablet layout

[BrayanDSO]

Purpose / Description

Improve the new reviewer style in tablets and make it more similar to Anki

Approach

Move the toolbar to the bottom of the screen and put the answer buttons there

How Has This Been Tested?

Emulator 35 in a lot of scenarios with the new reviewer settings (hide system bars; ignore display cutout; frame style; hide answer buttons; menu)

Details

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

[comment/non-blocking]

Is there any way that a 'smoke test' can be added here [load the UI in the emulated tests]?

Having two layouts makes it much more likely that an edit to one layout will break the other

[david-allison]

I think this looks unusual with the counts at the bottom

But, users will get used to it, it's just unfamiliarity on my behalf

[BrayanDSO]

Is there any way that a 'smoke test' can be added here [load the UI in the emulated tests]?

Done.

I think this looks unusual with the counts at the bottom

Anki/AnkiMobile has them at the bottom center. So I don't think that will be very unusual. Haven't put it at the bottom center because that either needs more vertical space (like in Anki desktop) or removes the Show answer test, which makes things less intuitive IMO (like in AnkiMobile). Also, leaving at the left makes the toolbar more symmetrical

[david-allison]

I think it's just the feeling of "it's new".

Mild concern about misclicks on the undo button and the lack of symmetry if more icons are added (could they be on both the left & right?)

But... it's forward progress. Let's do this

[BrayanDSO]

There's the alternative of making the menu size fixed and centralize the buttons instead of extending them, so it would be always symmetrical

[BrayanDSO]

1. The menu width is now restricted to two actions (more can still be scrolled) + the overflow menu, and it's quite symmetrical in that scenario.
2. If less options are used, the empty space is consumed (it looked better that way IMO)
3. If Hide answer buttons is set to true, the menu is expanded.
4. Also had to convert everything to a ConstraintLayout so I could avoid as much as possible doing stuff programatically

[mikehardy]

robolectric may be kinda heavy and kinda slow but it's because we get features like ability to load whole layouts outside an emulator in tests. Nice

[mikehardy]

I think it's cool - tablets have different layouts to be ergonomic and they seem a little weird at first (just unfamiliarity) but are then comfy and appreciated. This looks like one of those comfy and appreciated layout differences