Refactor(MediaCheckDialog): Media check to use ViewModel by criticalAY · Pull Request #17943 · ankidroid/Anki-Android

criticalAY · 2025-02-08T21:41:05Z

Purpose / Description

Migrates the logic of MediaCheck to ViewModel
Split the dialog logic, use different dialog for result and conformation

Fixes

Fixes App becomes unresponsive after clicking Check media #17983

Approach

Use ViewModel to handle the media check dialog and its result

How Has This Been Tested?

Tested on Google emulator API31
Screen_recording_20250220_045658.webm

Checklist

Please, go through these checks before submitting the PR.

You have a descriptive commit message with a short title (first line, max 50 chars).
You have commented your code, particularly in hard-to-understand areas
You have performed a self-review of your own code
UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
UI Changes: You have tested your change using the Google Accessibility Scanner

github-actions · 2025-02-08T21:41:16Z

Important

Maintainers: This PR contains Strings changes

Sync Translations before merging this PR and wait for the action to complete
Review and merge the auto-generated PR in order to sync all user-submitted translations
Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/mediacheck/ConfirmMediaCheckDialog.kt

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/mediacheck/MediaCheckResultDialog.kt

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/viewmodel/MediaCheckViewModel.kt

criticalAY · 2025-02-19T23:31:15Z

I have updated the latest test recording

To resolve the issue in

App becomes unresponsive after clicking Check media #17983

I am migrating the result from dialog to fragment. Why? Because the string builder is taking a lot of time to render strings i.e. 10k or 30k file names etc so its a heavy task for it, I have replicated the Anki behaviour in the fragment i.e. how it closes and how the user can interact with it

lukstbit

I don't see why you introduced the current granularity with the number of commits. Reverting any of the first three commits will render the other two commits useless as the content is tightly tied together. It also makes reviewing harder.

So please squash the first three commits into a single commit.

Requested some changes, the implementation seems fine.

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

AnkiDroid/src/main/java/com/ichi2/anki/mediacheck/ConfirmMediaCheckDialog.kt

AnkiDroid/src/main/java/com/ichi2/anki/mediacheck/MediaCheckAdapter.kt

AnkiDroid/src/main/res/layout/item_media_check.xml

AnkiDroid/src/main/java/com/ichi2/anki/mediacheck/MediaCheckFragment.kt

AnkiDroid/src/main/java/com/ichi2/anki/mediacheck/MediaCheckViewModel.kt

AnkiDroid/src/main/res/values/03-dialogs.xml

AnkiDroid/src/main/java/com/ichi2/anki/mediacheck/MediaCheckFragment.kt

Arthur-Milchior · 2025-03-19T22:36:19Z

Yeah, fine for me.
I guess I'll need to suggest to update upstream first then.

AnkiDroid/src/main/res/layout/item_media_check.xml

feat: add media check fragment file - feat: adapter for media check result - refactor: confirm media check dialog

- refactor: replace media check result dialog with fragment - refactor: remove unused parameter in Media.kt

david-allison

Looks great, cheers!

github-actions · 2025-03-24T19:28:24Z

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

github-actions bot added the Strings label Feb 8, 2025

criticalAY changed the title ~~Ref(MediaCheckDialog): Media check to use ViewModel~~ Refactor(MediaCheckDialog): Media check to use ViewModel Feb 8, 2025

criticalAY added the Blocked by dependency Currently blocked by some other dependent / related change label Feb 8, 2025

david-allison mentioned this pull request Feb 9, 2025

feat: Improve Check Media dialog #17842

Merged

5 tasks

david-allison reviewed Feb 9, 2025

View reviewed changes

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt Outdated Show resolved Hide resolved

criticalAY force-pushed the media-dialog-viewmodel branch from bc072d9 to 7a503ca Compare February 9, 2025 17:14

github-actions bot added the Has Conflicts label Feb 10, 2025

criticalAY force-pushed the media-dialog-viewmodel branch 2 times, most recently from 18ef3d5 to 6b62901 Compare February 10, 2025 13:52

criticalAY added Needs Review and removed Blocked by dependency Currently blocked by some other dependent / related change Has Conflicts labels Feb 10, 2025

criticalAY requested a review from david-allison February 17, 2025 07:10

david-allison reviewed Feb 17, 2025

View reviewed changes

criticalAY force-pushed the media-dialog-viewmodel branch from 6b62901 to 337a7d4 Compare February 17, 2025 20:42

criticalAY added the Needs Author Reply Waiting for a reply from the original author label Feb 19, 2025

criticalAY force-pushed the media-dialog-viewmodel branch 3 times, most recently from 93508d4 to 124a991 Compare February 19, 2025 23:25

criticalAY removed the Needs Author Reply Waiting for a reply from the original author label Feb 19, 2025

criticalAY force-pushed the media-dialog-viewmodel branch 2 times, most recently from 9090d16 to 37301c4 Compare February 19, 2025 23:47

criticalAY requested a review from david-allison February 19, 2025 23:47

david-allison added the Review High Priority Request for high priority review label Feb 20, 2025

lukstbit requested changes Feb 23, 2025

View reviewed changes

lukstbit added the Needs Author Reply Waiting for a reply from the original author label Feb 23, 2025

criticalAY force-pushed the media-dialog-viewmodel branch 2 times, most recently from 6ef3989 to 425ac64 Compare February 24, 2025 09:01

criticalAY force-pushed the media-dialog-viewmodel branch from 1ce4763 to 2500af3 Compare March 19, 2025 18:27

criticalAY removed the Needs Author Reply Waiting for a reply from the original author label Mar 19, 2025

criticalAY requested a review from david-allison March 19, 2025 18:28

david-allison reviewed Mar 20, 2025

View reviewed changes

AnkiDroid/src/main/res/layout/item_media_check.xml Outdated Show resolved Hide resolved

criticalAY force-pushed the media-dialog-viewmodel branch from 2500af3 to 3d0c793 Compare March 20, 2025 21:32

criticalAY requested a review from david-allison March 20, 2025 21:33

github-actions bot added the Has Conflicts label Mar 21, 2025

criticalAY force-pushed the media-dialog-viewmodel branch from 3d0c793 to b05e123 Compare March 22, 2025 09:12

criticalAY removed the Has Conflicts label Mar 22, 2025

criticalAY requested review from david-allison and removed request for david-allison March 22, 2025 09:13

github-actions bot added the Has Conflicts label Mar 23, 2025

criticalAY force-pushed the media-dialog-viewmodel branch from b05e123 to 6e4bd81 Compare March 24, 2025 06:52

criticalAY removed the Has Conflicts label Mar 24, 2025

criticalAY added 2 commits March 24, 2025 12:30

feat: media check viewmodel

ff91873

feat: add media check fragment file - feat: adapter for media check result - refactor: confirm media check dialog

refactor: remove unused code

aafcb92

- refactor: replace media check result dialog with fragment - refactor: remove unused parameter in Media.kt

criticalAY force-pushed the media-dialog-viewmodel branch from 6e4bd81 to aafcb92 Compare March 24, 2025 07:01

david-allison approved these changes Mar 24, 2025

View reviewed changes

david-allison added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Review High Priority Request for high priority review Needs Second Approval Has one approval, one more approval to merge labels Mar 24, 2025

david-allison mentioned this pull request Mar 24, 2025

Updated strings from Crowdin 2025/03/24 17:54 #18154

Merged

david-allison added this pull request to the merge queue Mar 24, 2025

Merged via the queue into ankidroid:main with commit dc37ead Mar 24, 2025
9 checks passed

github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Mar 24, 2025

github-actions bot added this to the 2.21 release milestone Mar 24, 2025

david-allison mentioned this pull request Mar 24, 2025

Updated strings from Crowdin 2025/03/24 19:30 #18155

Merged

Uh oh!

Conversation

criticalAY commented Feb 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose / Description

Fixes

Approach

How Has This Been Tested?

Checklist

Uh oh!

github-actions bot commented Feb 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

criticalAY commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukstbit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Arthur-Milchior commented Mar 19, 2025

Uh oh!

Uh oh!

david-allison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

criticalAY commented Feb 8, 2025 •

edited

Loading

criticalAY commented Feb 19, 2025 •

edited

Loading