Skip to content

Fix SharedDecksActivity toolbar color for dark themes#18022

Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom
lukstbit:fix_sharedDecksToolbar
Feb 28, 2025
Merged

Fix SharedDecksActivity toolbar color for dark themes#18022
BrayanDSO merged 1 commit intoankidroid:mainfrom
lukstbit:fix_sharedDecksToolbar

Conversation

@lukstbit
Copy link
Copy Markdown
Member

Purpose / Description

Saw this when I fixed the empty cards report appearance in dark themes.

Light and plain, no change:
Screenshot from 2025-02-25 15-55-20Screenshot from 2025-02-25 16-01-41

Before/after:

Black:

Screenshot from 2025-02-25 15-53-07Screenshot from 2025-02-25 15-55-03

Dark:

Screenshot from 2025-02-25 15-53-25

Screenshot from 2025-02-25 15-54-45

How Has This Been Tested?

Verified the toolbar's appearance in all themes.

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

This toolbar wasn't using the proper theme attribute appBarColor.
@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Feb 25, 2025
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Feb 28, 2025
@BrayanDSO BrayanDSO added this pull request to the merge queue Feb 28, 2025
Merged via the queue into ankidroid:main with commit 2484881 Feb 28, 2025
12 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Feb 28, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Feb 28, 2025
@lukstbit lukstbit deleted the fix_sharedDecksToolbar branch March 2, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants