Fix Toolbar Visibility in Fullscreen Reviewer Mode#18025
Closed
theMr17 wants to merge 3 commits intoankidroid:mainfrom
Closed
Fix Toolbar Visibility in Fullscreen Reviewer Mode#18025theMr17 wants to merge 3 commits intoankidroid:mainfrom
theMr17 wants to merge 3 commits intoankidroid:mainfrom
Conversation
| if (!ensureStoragePermissions()) { | ||
| return | ||
| } | ||
| enableEdgeToEdge() |
Member
There was a problem hiding this comment.
Is this needed even in non-fullscreen mode?
Contributor
Author
There was a problem hiding this comment.
@ShridharGoel, this is not a new change. Previously, android:fitsSystemWindows="true" was set in all modes directly in the XML files. I have now moved it to the activity using enableEdgeToEdge(), ensuring a single source of truth instead of declaring it separately in each XML file for this activity.
Member
|
Closing this in favor of the new study screen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
This PR fixes the bug where the toolbar is hidden in semi-fullscreen reviewer.
Fixes
Approach
BUTTONS_ONLYtoBUTTONS_AND_MENU_ONLY.BUTTONS_AND_MENUtoBUTTONS_AND_MENU_WITH_STATUS_BAR.enableEdgeToEdge()in Reviewer.fitsSystemWindowsto excludeBUTTONS_AND_MENU_WITH_STATUS_BAR.fitsSystemWindowstotrueinreviewer_fullscreen_noanswers.xmlto ensure that the card content does not get obscured by the camera cutout.fitsSystemWindowsfromreviewer_answer_buttons.fullscreenReviewpreference to use new enum.How Has This Been Tested?
Checklist
Please, go through these checks before submitting the PR.