fix: "Toggle whiteboard" control icon & label do not match#18027
Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom Mar 12, 2025
Merged
fix: "Toggle whiteboard" control icon & label do not match#18027BrayanDSO merged 1 commit intoankidroid:mainfrom
BrayanDSO merged 1 commit intoankidroid:mainfrom
Conversation
Contributor
|
Important Maintainers: This PR contains Strings changes
|
BrayanDSO
requested changes
Feb 28, 2025
Member
BrayanDSO
left a comment
BrayanDSO
left a comment
There was a problem hiding this comment.
If you are going to fix something, only do that in the PR.
Any kind of new features like the new control preference should be sugggested first in the forums so people can discuss it
BrayanDSO
added
the
Needs Author Reply
Contributor
|
is this issue solved ?. |
snowtimeglass
force-pushed
the
fix-whiteboard-controls
branch
from
ba17024 to
1feb986
Compare
For the "Toggle whiteboard" label in Controls settings page, replace the current "Show/Hide whiteboard" icon with "Enable whiteboard" icon, which is consistent with the control's actual action.
snowtimeglass
force-pushed
the
fix-whiteboard-controls
branch
from
1feb986 to
9795df1
Compare
Contributor
Author
|
In the updated PR, I only changed the icon of the control item. |
david-allison
approved these changes
Mar 11, 2025
david-allison
added
Needs Second Approval
BrayanDSO
approved these changes
Mar 12, 2025
BrayanDSO
added
Pending Merge
github-actions
bot
removed
the
Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Approach has been updated]
Purpose / Description
"Toggle whiteboard" control icon does not match the label and the actual action.
Fixes
Approach
How Has This Been Tested?
Checked on physical device (Android 11)
Checklist
Please, go through these checks before submitting the PR.