Skip to content

improvement(deck-options): optimize using native UI #18454

Merged
BrayanDSO merged 2 commits intoankidroid:mainfrom
david-allison:18006-optimize-string
Jun 9, 2025
Merged

improvement(deck-options): optimize using native UI #18454
BrayanDSO merged 2 commits intoankidroid:mainfrom
david-allison:18006-optimize-string

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Jun 8, 2025 •
edited by lukstbit
Loading

Purpose / Description

Due to a bug in latestProgress, I made a dialog to show optimization progress

This fixes the underlying issue

Fixes

Approach

  • make latestProgress non-blocking
  • remove the dialog

How Has This Been Tested?

image

Pixel 9 Pro

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

lukstbit
lukstbit approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

This was blocking the import progress so it also fixes

It would also be nice to see this in production and then check again

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jun 9, 2025
david-allison
david-allison commented Jun 9, 2025
View reviewed changes
@david-allison
fix(deck-options): display 'optimize' progress in UI
2a6c2f2 
`latestProgress` should not be a blocking call

So this now appears in the Svelte page

Issue 18006
Fixes 17862
@david-allison
improvement(deck-options): optimize using native UI
65bb926 
In the previous commit, we enabled a native UI for optimization

Fixes 18006
@david-allison david-allison force-pushed the 18006-optimize-string branch from 96f9cfc to 65bb926 Compare June 9, 2025 11:00
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jun 9, 2025
@BrayanDSO BrayanDSO added this pull request to the merge queue Jun 9, 2025
Merged via the queue into ankidroid:main with commit b06a0e5 Jun 9, 2025
9 checks passed
@github-actions github-actions bot added this to the 2.21 release milestone Jun 9, 2025
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jun 9, 2025
@david-allison david-allison deleted the 18006-optimize-string branch June 9, 2025 21:25
@david-allison david-allison mentioned this pull request Jun 11, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukstbit lukstbit lukstbit approved these changes

@BrayanDSO BrayanDSO BrayanDSO approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.21 release

Development

Successfully merging this pull request may close these issues.

Wrong progress message when optimizing current preset Importing a deck doesn't show the progress anymore

3 participants

@david-allison @lukstbit @BrayanDSO