[Multiple Profiles] - PR1- Add a switch in developer options to toggle the Switch Profiles in Settings preferences by oyeraghib · Pull Request #18484 · ankidroid/Anki-Android

oyeraghib · 2025-06-12T03:59:26Z

Purpose / Description

Add a switch in developer options to toggle the Switch Profiles option in Settings Preferences

Fixes

Part of Add support for profiles #18117

Approach

Add a switch in Developer options to toggle switch profiles options in Settings preferences
Add a shared prefs to store the key for enabling/disabling the feature
Based on the key's value we show/hide the option in preferences

How Has This Been Tested?

Manually tested on Google Pixel 6A

Steps:

Go to settings from nav drawer
Go to the Developer options
Enable/disbale the switch profile option
See changes on the Settings Fragment

Video changes:

WhatsApp.Video.2025-07-15.at.11.15.30.mp4

Learning (optional, can help others)

Describe the research stage

Checklist

Please, go through these checks before submitting the PR.

You have a descriptive commit message with a short title (first line, max 50 chars).
You have commented your code, particularly in hard-to-understand areas
You have performed a self-review of your own code
UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
UI Changes: You have tested your change using the Google Accessibility Scanner

github-actions · 2025-06-12T03:59:34Z

Important

Maintainers: This PR contains Strings changes

Sync Translations before merging this PR and wait for the action to complete
Review and merge the auto-generated PR in order to sync all user-submitted translations
Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

lukstbit

Thanks, left some comments.
Also, please squash the two commits together.

lukstbit · 2025-06-12T06:25:47Z

AnkiDroid/src/main/res/drawable/ic_switch_profiles.xml

@@ -0,0 +1,10 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"


Is this icon from the studio vector assets library?

No this one is from Google Material Icons here -

https://fonts.google.com/icons?selected=Material+Symbols+Outlined:group_add:FILL@0;wght@400;GRAD@0;opsz@24&icon.query=group+add&icon.size=24&icon.color=%23434343

lukstbit · 2025-06-12T06:32:51Z

AnkiDroid/src/main/java/com/ichi2/anki/preferences/DevOptionsFragment.kt

        }

+        // Helps to enable/disable the switch profiles feature in settings
+        findPreference<SwitchPreferenceCompat>(getString(R.string.enable_multiple_profiles_pref_key))


This entire code is not needed:

we are just interested in the value found in the associated key so there's no need for manual setup

there's no need for the toast, the switch behavior is clear

there's no need to recreate the activity

done!
Thanks

lukstbit · 2025-06-12T06:36:41Z

AnkiDroid/src/main/res/xml/preference_headers.xml

    </com.ichi2.preferences.HeaderPreference>

+    <!-- Switch Profiles Preferences  -->
+    <com.ichi2.preferences.HeaderPreference


Was this extra settings category discussed? I would think we don't need/have enough content for it especially as all sections have multiple groups of settings.

This was proposed by me during the GSoC proposal. I also suggested to add an icon on the top menu in DeckPicker, to which @david-allison suggested that it was too prominent and should rather be in Settings.
So I created an option in Settings. I agree that all sections have multiple groups of settings, so what do you suggest - should we keep it like this or move into some other section?

I suggest maybe we keep it like this and work on the switch profiles feature itself and later on if required we can just move it somewhere or keep it there. But to begin with Multiple profiles it is a good place and as it's under developer settings so it should be fine

Also, this makes it consistent with ankimobile, which have the list of profiles in the section.

@oyeraghib I'd be interested if you could link to your discussion with David please.
I don't even think an icon is useful here. I think we could imitate ankimobile and just have a text at the top stating which profile is used (if here are multiple profiles)

In any case, I agree that it'd be easy to move if we want to move it later.. would you have any idea of a better place to put the list of profile (and option to rename/delete one) @lukstbit ?

lukstbit · 2025-06-12T06:44:13Z

AnkiDroid/src/main/java/com/ichi2/anki/preferences/HeaderFragment.kt

    ) {
        setPreferencesFromResource(R.xml.preference_headers, rootKey)

+        fun shouldDisplaySwitchProfilesOption(context: Context): Boolean =


The oneline method is used only once, use a variable.

lukstbit · 2025-06-12T06:50:06Z

AnkiDroid/src/main/res/values/12-dont-translate.xml

+    <string name="switch_profiles_title" maxLength="41">Switch Profiles</string>
+
+    <string name="pref_switch_profiles_list">switch_profiles_list</string>
+


Only add strings that are actually used in the PR.

lukstbit · 2025-06-12T06:52:16Z

AnkiDroid/src/main/res/values/12-dont-translate.xml

+    <!-- Switch Profiles -->
+    <string name="multiple_profiles_screen_pref_key">multiple_profiles_screen</string>
+    <string name="enable_multiple_profiles_pref_key">enable_multiple_profiles</string>
+    <string name="switch_profiles_title" maxLength="41">Switch Profiles</string>


Wait a bit for other opinions on the new setting section, but consider:

the three strings above should be in 10-preferences.xml

use a name like the other keys use: pref_multiple_profiles_screen_key

the category title follow a specific pattern: pref_cat_switch_profiles

Not putting them inside the 10-preferences.xml as @Arthur-Milchior suggested that we should be keeping the string in 12-dont-translate.xml
So translators do not end up translating a string which would later change. So we keep it in dont-translate and when everything is completed we can move the strings to their respective places.

BrayanDSO · 2025-06-12T23:15:44Z

Manually tested on Google Pixel 6A

Please pay more attention to the message in the default PR template, and fill How's that been tested better

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration (SDK version(s), emulator or physical, etc)

oyeraghib · 2025-06-24T23:27:49Z

I am looking at the mentioned changes and these conflicts, will update the PR soon.

github-actions · 2025-07-13T12:50:34Z

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

* common & libanki I tried using `buildSrc`, but: * it doesn't support version catalogs out the box * it doesn't support `android { }` out the box Given we have such little logic, it felt prudent to stick with a `.gradle` `AnkiDroid/jacoco.gradle` exists, so use `jacocoSupport.gradle` Prep for 16618: common doesn't run tests

Tested by failing 'StringUtilsTest' and 'AnalyticsConstantsTest' Fixes 16618

Make it clickable in Android Studio terminal

GSoC 2025: Review Reminders - Makes `ReviewReminder` Parcelable so that it can be passed to and from the AddEditReminderDialog -- the AddEditReminderDialog will receive a `ReviewReminder` to edit via arguments and return one via a FragmentResult, `ReviewReminder` must be Parcelable to allow this to happen

`TrimLambda` inspection https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:lint/libs/lint-checks/src/main/java/com/android/tools/lint/checks/TrimDetector.kt The Kotlin standard library `trim()` call takes an optional lambda to specify which characters are considered whitespace. When converting Java code to Kotlin code, the converter will convert calls for Java's `s.trim()` into `s.trim() { it <= ' ' }`. This preserves the exact semantics of the Java code, but is likely not what you want: the default in Kotlin uses a better definition of what constitutes a whitespace character (`Char::isWhitespace`) and also results in less bytecode at the call-site.

Issue 18716

GSoC 2025: Review Reminders - When initializing the deck spinner in AddEditReminderDialog, I wanted to use initializeNoteEditorDeckSpinner, but it was annotated with MainThread which meant I couldn’t use withCol and would have had to use getColUnsafe, which I think we’re not supposed to use anymore? I wasn’t sure if I was allowed to refactor everything, so I created a new method that calls withCol internally and tried to copy the format of the other initialization methods. Are these methods supposed to be annotated with MainThread? There’s an annotation at the top of the file marked “this class is a mess…” so I assume it’s due for a refactoring?

this is the same idea from the unit test workflow that lets us dynamically expand our matrix based on manual workflow input from GitHub web UI

MIUI doesn't support Material You well - the color is based on the system background color, with no means to disable it. https://www.reddit.com/r/Xiaomi/comments/y6zclf/material_you_on_miui_13/ Since we are using a widget, we can't use custom themes as a fix So to fix the issue: duplicate the assets/layout as unthemed and fix them there AdaptionUtil code copied from 43151b6 and converted to Kotlin `circle_background` did not need to be duplicated as the background was tintable just tinting the star was not possible **Duplicate unthemed widget icons:** `@android:color/system_neutral1_100` => #E2E2E9 `@android:color/system_neutral1_600` => #5D5E64 `@android:color/system_neutral1_800` => #2F3036 `@android:color/system_neutral1_900` => #1A1B20 `@android:color/system_neutral1_1000` => #000000 `@android:color/system_accent1_300` => #94AAE4 `@android:color/system_accent1_400` => #7A90C8 `@android:color/system_accent1_500` => #6076AC `@android:color/system_accent1_600` => #475D92 `ic_anki_unthemed.xml`: accent1_300 => 500 `ic_anki_unthemed_finish.xml`: accent1_400 => 600 **widget_small_unthemed** `material_dynamic_primary60` => #7A90C8 Fixes 18869

oyeraghib · 2025-07-15T06:04:17Z

Manually tested on Google Pixel 6A

Please pay more attention to the message in the default PR template, and fill How's that been tested better

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration (SDK version(s), emulator or physical, etc)

Thanks! I have updated the PR description

Arthur-Milchior

I'm fine with PR, once the changes in 12-dont-translate are removed.

Arthur-Milchior · 2025-07-18T00:53:45Z

AnkiDroid/src/main/res/xml/preference_headers.xml

    </com.ichi2.preferences.HeaderPreference>

+    <!-- Switch Profiles Preferences  -->
+    <com.ichi2.preferences.HeaderPreference


Also, this makes it consistent with ankimobile, which have the list of profiles in the section.

@oyeraghib I'd be interested if you could link to your discussion with David please.
I don't even think an icon is useful here. I think we could imitate ankimobile and just have a text at the top stating which profile is used (if here are multiple profiles)

In any case, I agree that it'd be easy to move if we want to move it later.. would you have any idea of a better place to put the list of profile (and option to rename/delete one) @lukstbit ?

Arthur-Milchior · 2025-07-18T00:56:28Z

AnkiDroid/src/main/res/values/12-dont-translate.xml

+    <!-- Switch Profiles: In progress for Switch Profile feature -->
+    <string name="pref_switch_screen_key">switch_profile_screen</string>
+    <string name="pref_enable_switch_profile_key">enable_switch_profile</string>
+    <string name="switch_profile_title" maxLength="41">Switch Profile</string>


If I recall correctly, we ended up deciding not to use 12-dont-translate, but to hard code the string in kotlin until we are actually certain of what UI we'll want. And just use a @Suppress to remove the warning

Here is the link to the comment by David -
https://docs.google.com/document/d/1vvfdsReSLuSqvK0TrhGrzWZAbGf2r_o1NehVz9fm6iA/edit?disco=AAABfwHvoy8

Arthur-Milchior · 2025-07-18T00:57:58Z

AnkiDroid/src/main/res/values/12-dont-translate.xml

    <string name="schedule_reminders_do_not_translate" maxLength="28" comment="Do not translate this string, this feature is still in development. Name of the screen that appears when review reminders are being scheduled.">Schedule reminders</string>
+
+    <!-- Switch Profiles: In progress for Switch Profile feature -->
+    <string name="pref_switch_screen_key">switch_profile_screen</string>


This file is fro strings that the user will see.
To see where to put such a key, please look at where similar keys are.

For example, you could see that pref_appearance_screen_key, which similaryl is used in preference_headers.xml, is declared in values/preferences.xml.

david-allison · 2025-07-18T12:22:51Z

AnkiDroid/src/main/java/com/ichi2/anki/preferences/HeaderFragment.kt

+    override fun onResume() {
+        super.onResume()
+        Timber.d("onResume")
+        updateSwitchProfileVisibility()
+    }


This doesn't work on tablets

yeah, remove it and call ActivityCompat.recreate in the dev options switch

david-allison · 2025-07-18T12:23:36Z

AnkiDroid/src/main/java/com/ichi2/anki/preferences/HeaderFragment.kt

        requirePreference<HeaderPreference>(R.string.pref_notifications_screen_key).isVisible = !Prefs.newReviewRemindersEnabled

+        // switch profile
+        updateSwitchProfileVisibility()


keep this code similar to the above (inline the function)

david-allison · 2025-07-18T12:26:00Z

...id/src/main/java/com/ichi2/anki/preferences/switchProfiles/SwitchProfilesSettingsFragment.kt

+    override val analyticsScreenNameConstant: String
+        get() = "pref.switchProfiles"
+
+    override fun initSubscreen() {


Call this on change to handle tablet mode

ActivityCompat.recreate(requireActivity())

BrayanDSO · 2025-07-18T14:31:59Z

AnkiDroid/src/main/java/com/ichi2/anki/preferences/switchProfiles/ProfileListPreference.kt

+ * You should have received a copy of the GNU General Public License along with         *
+ * this program.  If not, see <http://www.gnu.org/licenses/>.                           *
+ ****************************************************************************************/
+package com.ichi2.anki.preferences.switchProfiles


package names should be in lower case https://docs.oracle.com/javase/tutorial/java/package/namingpkgs.html

also, profiles is enough. Doesn't need the switch prefix IMO

BrayanDSO · 2025-07-18T14:33:15Z

AnkiDroid/src/main/java/com/ichi2/anki/preferences/switchProfiles/ProfileListPreference.kt

+import androidx.preference.Preference
+import androidx.preference.PreferenceViewHolder
+
+class ProfileListPreference(


This class does nothing. If you are going to do something with it later, add it as a separate commit in a future PR. As of now, I can't tell if this will be necessary.

BrayanDSO · 2025-07-18T14:33:42Z

...id/src/main/java/com/ichi2/anki/preferences/switchProfiles/SwitchProfilesSettingsFragment.kt

+import com.ichi2.anki.R
+import com.ichi2.anki.preferences.SettingsFragment
+
+class SwitchProfilesSettingsFragment : SettingsFragment() {


ProfilesSettingsFragment

BrayanDSO · 2025-07-18T14:34:58Z

AnkiDroid/src/main/java/com/ichi2/anki/settings/Prefs.kt

+    /**
+     * Whether the switch profiles feature is enabled.
+     */
+    var switchProfileEnabled by booleanPref(R.string.pref_enable_switch_profile_key, false)


Suggested change

var switchProfileEnabled by booleanPref(R.string.pref_enable_switch_profile_key, false)

val switchProfileEnabled by booleanPref(R.string.pref_enable_switch_profile_key, false)

Also, put it below the Developer options heading if this is just a flag for a WIP dev option

BrayanDSO · 2025-07-18T14:35:35Z

AnkiDroid/src/main/java/com/ichi2/anki/preferences/HeaderFragment.kt

        requirePreference<HeaderPreference>(R.string.pref_review_reminders_screen_key).isVisible = Prefs.newReviewRemindersEnabled
        requirePreference<HeaderPreference>(R.string.pref_notifications_screen_key).isVisible = !Prefs.newReviewRemindersEnabled

+        // switch profile


remove this comment

BrayanDSO · 2025-07-18T14:36:05Z

AnkiDroid/src/main/java/com/ichi2/anki/preferences/HeaderFragment.kt

+    override fun onResume() {
+        super.onResume()
+        Timber.d("onResume")
+        updateSwitchProfileVisibility()
+    }


yeah, remove it and call ActivityCompat.recreate in the dev options switch

BrayanDSO · 2025-07-18T14:36:23Z

...id/src/main/java/com/ichi2/anki/preferences/switchProfiles/SwitchProfilesSettingsFragment.kt

+        get() = R.xml.preferences_switch_profiles
+
+    override val analyticsScreenNameConstant: String
+        get() = "pref.switchProfiles"


Suggested change

get() = "pref.switchProfiles"

get() = "pref.profiles"

github-actions bot added the Strings label Jun 12, 2025

oyeraghib force-pushed the multi-profiles/add-multi-profile-boolean-in-dev branch 3 times, most recently from fa89ba4 to cd19c6b Compare June 12, 2025 05:04

lukstbit added the squash-merge A squash & force push is required. The PR author may do this to speed up the merge process. label Jun 12, 2025

lukstbit requested changes Jun 12, 2025

View reviewed changes

BrayanDSO added the Needs Author Reply Waiting for a reply from the original author label Jun 12, 2025

github-actions bot added the Has Conflicts label Jun 19, 2025

github-actions bot added the Stale label Jul 13, 2025

david-allison and others added 9 commits July 13, 2025 15:11

build(ci): test :common & :libanki

5f657f8

Tested by failing 'StringUtilsTest' and 'AnalyticsConstantsTest' Fixes 16618

build(tests): improve Jacoco HTML Report link

c0f3592

Make it clickable in Android Studio terminal

logs: diagnostics for collectionLoadError

91c43fb

Issue 18716

test(ci): dynamic iteration control for emulator tests

7738c11

this is the same idea from the unit test workflow that lets us dynamically expand our matrix based on manual workflow input from GitHub web UI

oyeraghib force-pushed the multi-profiles/add-multi-profile-boolean-in-dev branch 2 times, most recently from 329a34d to 769f945 Compare July 15, 2025 05:42

github-actions bot removed the Stale label Jul 15, 2025

oyeraghib force-pushed the multi-profiles/add-multi-profile-boolean-in-dev branch from 769f945 to baf1ea2 Compare July 15, 2025 05:53

oyeraghib requested a review from lukstbit July 15, 2025 06:10

david-allison removed Needs Author Reply Waiting for a reply from the original author Has Conflicts labels Jul 15, 2025

david-allison added the Needs Review label Jul 15, 2025

mikehardy force-pushed the main branch from a7ee965 to dab784f Compare July 17, 2025 17:04

github-actions bot added the Has Conflicts label Jul 17, 2025

Arthur-Milchior force-pushed the multi-profiles/add-multi-profile-boolean-in-dev branch from baf1ea2 to b8aba82 Compare July 18, 2025 00:45

Arthur-Milchior approved these changes Jul 18, 2025

View reviewed changes

david-allison requested changes Jul 18, 2025

View reviewed changes

BrayanDSO requested changes Jul 18, 2025

View reviewed changes

feat: add toggle to enable/disable switch profiles feature

da9712c

oyeraghib force-pushed the multi-profiles/add-multi-profile-boolean-in-dev branch from b8aba82 to da9712c Compare July 20, 2025 17:53

Merge branch 'main' into multi-profiles/add-multi-profile-boolean-in-dev

faf4b93

oyeraghib requested review from Arthur-Milchior, BrayanDSO and david-allison July 20, 2025 18:12

criticalAY mentioned this pull request Aug 26, 2025

feat: add multiple profile as developer option #19143

Merged

5 tasks

lukstbit closed this Oct 22, 2025

		@@ -0,0 +1,10 @@
		<vector xmlns:android="http://schemas.android.com/apk/res/android"

		<string name="switch_profiles_title" maxLength="41">Switch Profiles</string>

		<string name="pref_switch_profiles_list">switch_profiles_list</string>

	var switchProfileEnabled by booleanPref(R.string.pref_enable_switch_profile_key, false)
	val switchProfileEnabled by booleanPref(R.string.pref_enable_switch_profile_key, false)

Uh oh!

Conversation

oyeraghib commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose / Description

Fixes

Approach

How Has This Been Tested?

Learning (optional, can help others)

Checklist

Uh oh!

github-actions bot commented Jun 12, 2025

Uh oh!

lukstbit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oyeraghib Jun 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BrayanDSO commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oyeraghib commented Jun 24, 2025

Uh oh!

github-actions bot commented Jul 13, 2025

Uh oh!

oyeraghib commented Jul 15, 2025

Uh oh!

Arthur-Milchior left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oyeraghib commented Jun 12, 2025 •

edited

Loading

oyeraghib Jun 29, 2025 •

edited

Loading

BrayanDSO commented Jun 12, 2025 •

edited

Loading