Skip to content

feat(preferences): shortcut for 'Display screen shortcuts'#18489

Closed
david-allison wants to merge 1 commit intoankidroid:mainfrom
david-allison:app-shortcuts
Closed

feat(preferences): shortcut for 'Display screen shortcuts'#18489
david-allison wants to merge 1 commit intoankidroid:mainfrom
david-allison:app-shortcuts

Conversation

@david-allison
Copy link
Member

Purpose / Description

'Show keyboard shortcuts' was unintuitive: app shortcuts only showed Ctrl+Z

Fixes

Approach

This makes the 'Access list of system / apps shortcuts' more prominent by including it in the 'Current app' tab

⚠️ It may be buggy on custom Android systems which change this default shortcut, but should work for the vast majority of systems

How Has This Been Tested?

API 34 tablet emulator

Screenshot 2025-06-12 at 13 48 59

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

'Show keyboard shortcuts' was unintuitive: app shortcuts only showed
Ctrl+Z

This makes the 'Access list of system / apps shortcuts' more prominent
by including it in the 'Current app' tab

It may be buggy on custom Android systems
which change this default shortcut, but should
work for the vast majority of systems

Fixes 18488
@github-actions
Copy link
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@david-allison david-allison marked this pull request as ready for review June 12, 2025 12:50
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@BrayanDSO BrayanDSO added the Needs Second Approval Has one approval, one more approval to merge label Jun 12, 2025
Copy link
Member

@sanjaysargam sanjaysargam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀 🚀

@david-allison david-allison added this pull request to the merge queue Jun 12, 2025
@david-allison david-allison removed this pull request from the merge queue due to a manual request Jun 12, 2025
@david-allison
Copy link
Member Author

@david-allison david-allison added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jun 12, 2025
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna remove my approval for now. I need to test it on my tablet.

@BrayanDSO BrayanDSO self-requested a review June 12, 2025 13:15
@BrayanDSO BrayanDSO added Needs Review and removed Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) labels Jun 12, 2025
@BrayanDSO
Copy link
Member

BrayanDSO commented Jun 12, 2025

It may be buggy on custom Android systems which change this default shortcut

I believe that the shortcut is based on the keyboard, not the system. If you are adding a shortcut that may not work, don't do it.

@BrayanDSO
Copy link
Member

I know that the shortcut in my Samsung Tablet is CMD + ;.

Adding a shortcut duplicate to make it more clear to the user is okay.

If you can't be sure that the shortcut is correct, don't do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show keyboard shortcuts: more prominently display "Access list of system / apps shortcuts"

3 participants