refactor: Move most CardBrowser methods to CardBrowserFragment#18723
Merged
mikehardy merged 21 commits intoankidroid:mainfrom Aug 3, 2025
Merged
refactor: Move most CardBrowser methods to CardBrowserFragment#18723mikehardy merged 21 commits intoankidroid:mainfrom
mikehardy merged 21 commits intoankidroid:mainfrom
Conversation
4f61501 to
ba11142
Compare
ba11142 to
231f5bf
Compare
231f5bf to
c17bbf8
Compare
BrayanDSO
reviewed
Jul 28, 2025
AnkiDroid/src/main/java/com/ichi2/anki/browser/CardBrowserFragment.kt
Outdated
Show resolved
Hide resolved
* toggleMark * toggleSuspendCards * toggleBury
* searchForMarkedNotes * searchForSuspendedCards
* showEditTagsDialog * showFilterByTagsDialog
* searchForMarkedNotes * searchForSuspendedCards
c17bbf8 to
a1e9cb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was looking into
I found that I wanted to:
SearchBar/SearchViewThese changes have been done on a branch for (1) and (3), but it feels like a 'huge' functional chance that I'll struggle to get reviewed with the Browser in its current state.
This PR moves us closer to (2), and closer to:
CardBrowserFragmentViewModelCardBrowserFragmentViewModelFixes
Approach
onKeyUpandonOptionsItemSelectedfor these methods into theCardBrowserFragment, removingHow Has This Been Tested?
CI
Checklist