Skip to content

feat: display user-facing FSRS version#18826

Merged
lukstbit merged 1 commit intoankidroid:mainfrom
david-allison:fsrs-version
Jul 12, 2025
Merged

feat: display user-facing FSRS version#18826
lukstbit merged 1 commit intoankidroid:mainfrom
david-allison:fsrs-version

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Jul 9, 2025

This was causing confusion for users

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

This was causing confusion for users

Fixes 18825

class FsrsTest {
@Test
fun `FSRS version is mapped to user-facing version`() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break on backend update - feels like the right thing to do for now

Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jul 10, 2025
@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jul 12, 2025
@lukstbit lukstbit added this pull request to the merge queue Jul 12, 2025
Merged via the queue into ankidroid:main with commit d353d13 Jul 12, 2025
12 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jul 12, 2025
@david-allison david-allison deleted the fsrs-version branch July 12, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose user-facing FSRS version

3 participants