Skip to content

Improve ReviewRemindersDatabase docstrings#18827

Merged
david-allison merged 1 commit intoankidroid:mainfrom
ericli3690:ericli3690-review-reminders-better-database-docstrings
Jul 11, 2025
Merged

Improve ReviewRemindersDatabase docstrings#18827
david-allison merged 1 commit intoankidroid:mainfrom
ericli3690:ericli3690-review-reminders-better-database-docstrings

Conversation

@ericli3690
Copy link
Member

@ericli3690 ericli3690 commented Jul 10, 2025 •
edited
Loading

Purpose / Description

  • Cleaned up docstrings in ReviewRemindersDatabase

Fixes

  • For GSoC 2025: Review Reminders
  • Requested by Arthur

Approach

  • Fixed typos and clarified wording

How Has This Been Tested?

  • Only comment changes

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code

@ericli3690 ericli3690 added Needs Review GSoC Pull requests authored by a Google Summer of Code participant [Candidate/Selected], for GSoC mentors labels Jul 10, 2025
david-allison
david-allison approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jul 10, 2025
criticalAY
criticalAY approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@criticalAY criticalAY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@criticalAY criticalAY added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jul 10, 2025
@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Jul 10, 2025
@ericli3690 ericli3690 removed the Needs Author Reply Waiting for a reply from the original author label Jul 11, 2025
@david-allison david-allison force-pushed the ericli3690-review-reminders-better-database-docstrings branch from 652cabd to 3ab1114 Compare July 11, 2025 03:09
@david-allison david-allison enabled auto-merge July 11, 2025 03:09
@david-allison
Copy link
Member

david-allison commented Jul 11, 2025

squashed, modified commit message & force pushed. Let's get this in

@david-allison david-allison added this pull request to the merge queue Jul 11, 2025
Merged via the queue into ankidroid:main with commit 4bde5a5 Jul 11, 2025
9 checks passed
@github-actions github-actions bot added this to the 2.22 release milestone Jul 11, 2025
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@criticalAY criticalAY criticalAY approved these changes

@david-allison david-allison david-allison approved these changes

Assignees

No one assigned

Labels

GSoC Pull requests authored by a Google Summer of Code participant [Candidate/Selected], for GSoC mentors

Projects

None yet

Milestone

2.22 release

Development

Successfully merging this pull request may close these issues.

3 participants

@ericli3690 @david-allison @criticalAY