ReviewRemindersScope for ScheduleReminders entry#18829
Merged
david-allison merged 1 commit intoankidroid:mainfrom Jul 10, 2025
Merged
ReviewRemindersScope for ScheduleReminders entry#18829david-allison merged 1 commit intoankidroid:mainfrom
david-allison merged 1 commit intoankidroid:mainfrom
Conversation
ericli3690
added
Needs Review
GSoC
Member
|
Heya, could you rebase the |
Member
Author
|
Oops, my bad, super sorry! |
GSoC 2025: Review Reminders - Refactored ScheduleReminders to take a ReviewReminderScope as an argument in `getIntent` to better enforce that callers should either trigger ScheduleReminders in deck-specific or global mode rather than leaving open the possibility of passing an incorrect deckId, etc. This was recommended by David. - Made toolbar title use ReviewReminderScope to follow the above change - Modified review reminder entry points to pass a ReviewReminderScope rather than the old `getIntent` arguments
ericli3690
force-pushed
the
ericli3690-review-reminders-get-intent
branch
from
04ef12e to
bc66bf8
Compare
Member
|
No worries! Cheers |
david-allison
approved these changes
Jul 10, 2025
AnkiDroid/src/main/java/com/ichi2/anki/reviewreminders/ScheduleReminders.kt
Show resolved
Hide resolved
| decks.name(did) | ||
| } | ||
| } | ||
| private fun reloadToolbarText() { |
Member
There was a problem hiding this comment.
optional: may not require a method - only called once
Member
Author
There was a problem hiding this comment.
Good catch, but I'll keep it separated for now. I originally pulled it out because it was used when switching multi-select mode on and off. Perhaps we could remove it now that I'm getting rid of multi-select, but onViewCreated() is about to get QUITE long so I'll keep it pulled out into a submethod for readability's sake. Thanks!
david-allison
added
Needs Second Approval
criticalAY
added
Pending Merge
github-actions
bot
removed
the
Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
getIntentto better enforce that callers should either trigger ScheduleReminders in deck-specific or global mode rather than leaving open the possibility of passing an incorrect deckId, etc. This was recommended by David.getIntentargumentsFixes
Approach
How Has This Been Tested?
Checklist