Refactor NoteEditor to use a AnkiActivity instead of SingleFragmentActivity

[Haz3-jolt]

Purpose / Description

• Renames note_editor.xml to note_editor_fragment.xml
• Introduce Activity to Host NoteEditor

Fixes

• Refactor as part of fixes for Add Previewer to NoteEditor #18724

Approach

• Introduces NoteEditorActivity
• Uses a Interface in NoteEditorFragment to get toolbar from activity layout

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[Haz3-jolt]

@david-allison I think LayoutValidationTest is flaky. I tried running it locally on my main branch and it still fails.

[BrayanDSO]

You can specify the number of iterations of the Unit tests workflow to test if something is flaky.

[david-allison]

Cheers! CI failure

[david-allison]

CI is passing on main. It's likely related to this PR If all 3 test runs failed

[Haz3-jolt]

Cheers! CI failure

Tried many reruns, LayoutValidationTest seems to fail on a fresh branch? What should I do about it

[Haz3-jolt]

CI is passing on main. It's likely related to this PR If all 3 test runs failed

I'll check again

[sanjaysargam]

@Haz3-jolt
Input field is not gaining focus, so the keyboard isn’t appearing.

[Haz3-jolt]

@Haz3-jolt Input field is not gaining focus, so the keyboard isn’t appearing.

Yeah I kinda don't understand why showsoftinput isn't working when requestfocus() seems to work fine. I'll try to get it fixed

[david-allison]

Looking great! I believe there's an issue with replace if Don't Keep Activities is enabled (Fragment would lose state on restore)

[david-allison]

Looks great, cheers!

stale