Skip to content

refactor: move usingStyledAttributes#18847

Merged
BrayanDSO merged 2 commits intoankidroid:mainfrom
BrayanDSO:ref-using
Jul 11, 2025
Merged

refactor: move usingStyledAttributes#18847
BrayanDSO merged 2 commits intoankidroid:mainfrom
BrayanDSO:ref-using

Conversation

@BrayanDSO
Copy link
Member

The name is still the same to mimic the default method withStyledAttributes

Suggested by @david-allison in #18797 (comment)

Approach

In the commit description

How Has This Been Tested?

Trusting CI

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison enabled auto-merge July 11, 2025 22:47
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Jul 11, 2025
@BrayanDSO BrayanDSO disabled auto-merge July 11, 2025 23:02
@BrayanDSO BrayanDSO added the Needs Author Reply Waiting for a reply from the original author label Jul 11, 2025
necessary to satisfy ktLint in the next commit
@BrayanDSO BrayanDSO removed the Needs Author Reply Waiting for a reply from the original author label Jul 11, 2025
The name is still the same to mimic the default method `withStyledAttributes`
@BrayanDSO BrayanDSO enabled auto-merge July 11, 2025 23:14
@BrayanDSO BrayanDSO added this pull request to the merge queue Jul 11, 2025
Merged via the queue into ankidroid:main with commit 105b993 Jul 11, 2025
9 checks passed
@github-actions github-actions bot added this to the 2.22 release milestone Jul 11, 2025
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jul 11, 2025
@BrayanDSO BrayanDSO deleted the ref-using branch July 12, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants